-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubeflow 1.2 release doc changes #2322
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
@8bitmp3 @RFMVasconcelos Do you have capacity to drive 1.2 website release? |
Thank you for creating this issue @Jeffwan! I can help drive this effort. Do you say you'll cut a 1.1 branch on Nov 8th? |
@Jeffwan Why we will cut 1.1 branch ? Am I misunderstanding something ? |
@RFMVasconcelos @andreyvelich Typo..I correct the branch name, it should be v1.2-branch. @RFMVasconcelos Thanks. If you can help drive this and cut v1.2-branch on website. That would be great. I |
Hi @Jeffwan @andreyvelich ! So the way we do it is that we change If you look, today we don't have a |
Happy to drive the cut of |
@jlewi, it seems that I do not have the permissions to create a new branch upstream. Would it be possible to give me these permissions, or can someone else do this? |
Thank you! |
Adding permissions needed to create new branch -> see [v1.2 docs release issue](kubeflow/website#2322 (comment))
@jlewi I created the PR to update permissions. ☝️ |
@RFMVasconcelos I get some feedbacks from WG owners. Most WGs owners just finish code and manifest updates this week. They are working on docs changes. Can we postpone the website branch cut a little bit late? I propose to do it on Nov 11 instead of the end of this week. What do you think? one example is #2322 (comment) /cc @andreyvelich |
@Jeffwan that's ok! I can do it early next week ;) These updates are things we will want to stay in Kubeflow v1.1 docs? |
em. See kubeflow/kubeflow#5371 (comment) So I think we don't want those changes coming into v1.1 since they are v1.2 only. Can we accept new changes on master and then cut branch from a stable commit without v1.2 related changes? Any better ideas? |
I think if we want to cut the v1.1 website release, we need to choose one of the past commits and make the release. For example: 97dc746. If we can't find the commit for the v1.1 website, we should skip this version and directly cut v1.2 for the Kubeflow 1.2 release, once all required PRs docs will be merged to the master. As I can see, currently the Kubeflow website points the master version to the 1.1 branch: I think it is not correct, because:
What do you think @Jeffwan @RFMVasconcelos ? |
Adding permissions needed to create new branch -> see [v1.2 docs release issue](kubeflow/website#2322 (comment))
@andreyvelich It's by design. see kubeflow/kubeflow#5371 (comment) it's a little bit different from other projects. I think both solution work. website normally is changed frequently when user notice there's issue for latest branch. If we follow kubeflow/kubeflow way, then
The v1.1 in banner doesn't mean there's a tag or version named v1.1. It's same as master. I know this is confuse, I think if most people want to do it in a different way, that works as well. |
@Jeffwan is correct
|
Sounds good @jlewi, @Jeffwan ! I am happy to make the @andreyvelich are there any merged docs that are v1.2 specific hence forcing a cut from a past commit? If not I'd rather do the cut at the current state. The commit you mention is 1 month old, which means some relevant commits might be lost, including some of our recent efforts to remove "outdated" banners. WDYT? |
@RFMVasconcelos From AutoML WG only this commit is related to 1.2: 1df2cb9. |
Ok @Jeffwan! From the meeting, it seemed like nobody had big objections. I will use that commit and then ask the leads to review if there is any inconsistency on the |
Branch created -> https://github.com/kubeflow/website/tree/v1.1-branch |
Netlify deployed v1.1 version: |
Hey @jlewi @Bobgy, I've done steps 1 & 2 of the "Creating and publishing a website branch for vX.Y" guide. ☝️ I'm stuck on step 3, as I don't have access to the Cloud DNS of Kubeflow.org. How should I proceed? |
One of @kubeflow/google-admins will have to do the DNS steps. |
Thank you for clarifying @jlewi. Could any of the @kubeflow/google-admins provide a timeline for this? Many thanks! |
I'll take a look tomorrow |
I've updated DNS record, https://v1-1-branch.kubeflow.org/ shows up correctly. It hasn't updated SSL certificate yet, I'm contacting netlify to set it up. |
After SSL ready, I'll do "Changing the version www.kubeflow.org points to" step |
Awesome! Let me know if you want me to do any of the next steps |
OK, SSL is now ready. I've also switched netlify to build v1.1-branch as kubeflow.org content. |
Hi @Bobgy! Thank you for the help! I can take care of that until EOW |
@RFMVasconcelos We cut code release. do you want to update the docs? |
Hey @Jeffwan! I have updated the website versioning -> #2365 Also opened issues for the following steps that are in the versioning guide:
|
@RFMVasconcelos are you going to cut a 1.2 branch, rather than just pointing to master? |
Shall we resolve the urgent issue first? We need to decide on a date when master will be shown as default for www.kubeflow.org instead of v1.1-branch.kubeflow.org. Doc updates on GCP side is almost done, I have one last PR waiting to be merged. |
/cc @Jeffwan |
@thesuperzapper we're going to point to master. It seems that we're only missing this step to update to v1.2. I think we're ready to do this @Bobgy. I do not have access to Netlify, perhaps this needs to be done by a Googler? |
GCP side is ready. /cc @kubeflow/aws @kubeflow/arrikto @kubeflow/azure @Jeffwan @animeshsingh Did I miss any stakeholders? If no one raises an objection, I will switch doc to master next Tuesday. |
@Bobgy Double check with Seldon @cliveseldon and KFServing @andreyvelich @animeshsingh Does IBM have a |
cc @kubeflow/wg-automl-leads @kubeflow/wg-notebook-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-training-leads @kubeflow/wg-serving-leads just to keep everyone in the loop |
From AutoML WG all required docs were updated on November 14th. |
Updated default branch to master, once the next commit lands in master, the website will switch over to master as default. |
Update from AWS Side, we have updated our doc to v1.2 |
It seems that v1.2 docs are live!! 🚀 Thank you for the help @Bobgy! /close |
@RFMVasconcelos: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I create this issue to track coming 1.2 doc changes. WG owners and platform owners, it would be great to link your WIG or PRs there to help on tracking.
We will cut a 1.2 branch from masters around Nov 8.
Docs for versioning the website: https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#version-the-website
The text was updated successfully, but these errors were encountered: