Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeflow 1.2 release doc changes #2322

Closed
Jeffwan opened this issue Oct 29, 2020 · 48 comments
Closed

Kubeflow 1.2 release doc changes #2322

Jeffwan opened this issue Oct 29, 2020 · 48 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Oct 29, 2020

I create this issue to track coming 1.2 doc changes. WG owners and platform owners, it would be great to link your WIG or PRs there to help on tracking.

We will cut a 1.2 branch from masters around Nov 8.

Docs for versioning the website: https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#version-the-website

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.79
area/docs 1.00

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 29, 2020

@8bitmp3 @RFMVasconcelos Do you have capacity to drive 1.2 website release?

@rui-vas
Copy link
Contributor

rui-vas commented Oct 30, 2020

Thank you for creating this issue @Jeffwan!

I can help drive this effort. Do you say you'll cut a 1.1 branch on Nov 8th?

@andreyvelich
Copy link
Member

andreyvelich commented Oct 30, 2020

@Jeffwan Why we will cut 1.1 branch ?
I assumed 1.1 branch had to be cut when we released Kubeflow 1.1 ?
And on 8th of November we should cut 1.2 branch.

Am I misunderstanding something ?

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 30, 2020

@RFMVasconcelos @andreyvelich Typo..I correct the branch name, it should be v1.2-branch.

@RFMVasconcelos Thanks. If you can help drive this and cut v1.2-branch on website. That would be great. I

@rui-vas
Copy link
Contributor

rui-vas commented Oct 31, 2020

Hi @Jeffwan @andreyvelich !

So the way we do it is that we change master to be the latest version, now -> v1.2, and we create a new branch for the previous version - v1.1.

If you look, today we don't have a v1.1-branch on the website repo as v1.1 is now in master

@rui-vas
Copy link
Contributor

rui-vas commented Nov 2, 2020

Happy to drive the cut of v1.1-branch this week.

@rui-vas
Copy link
Contributor

rui-vas commented Nov 5, 2020

@jlewi, it seems that I do not have the permissions to create a new branch upstream. Would it be possible to give me these permissions, or can someone else do this?

@rui-vas
Copy link
Contributor

rui-vas commented Nov 5, 2020

Thank you!

rui-vas added a commit to rui-vas/internal-acls that referenced this issue Nov 6, 2020
Adding permissions needed to create new branch -> see [v1.2 docs release issue](kubeflow/website#2322 (comment))
@rui-vas
Copy link
Contributor

rui-vas commented Nov 6, 2020

@jlewi I created the PR to update permissions. ☝️

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 6, 2020

@RFMVasconcelos I get some feedbacks from WG owners. Most WGs owners just finish code and manifest updates this week. They are working on docs changes. Can we postpone the website branch cut a little bit late? I propose to do it on Nov 11 instead of the end of this week. What do you think?

one example is #2322 (comment) /cc @andreyvelich

@rui-vas
Copy link
Contributor

rui-vas commented Nov 6, 2020

@Jeffwan that's ok! I can do it early next week ;)

These updates are things we will want to stay in Kubeflow v1.1 docs?

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 6, 2020

em. See kubeflow/kubeflow#5371 (comment)
doc repo is managed in a different way. it lags 1 version. The time we cut v1.1-branch, that means v1.1 is not the latest version and all changes on master will also go online (kubeflow.org points to master).

So I think we don't want those changes coming into v1.1 since they are v1.2 only. Can we accept new changes on master and then cut branch from a stable commit without v1.2 related changes? Any better ideas?

@andreyvelich
Copy link
Member

andreyvelich commented Nov 6, 2020

I think if we want to cut the v1.1 website release, we need to choose one of the past commits and make the release. For example: 97dc746.
I believe the multi-user doc for the Kubeflow Pipelines was ready at this time.

If we can't find the commit for the v1.1 website, we should skip this version and directly cut v1.2 for the Kubeflow 1.2 release, once all required PRs docs will be merged to the master.

As I can see, currently the Kubeflow website points the master version to the 1.1 branch:
Screenshot 2020-11-06 at 22 36 16

I think it is not correct, because:

  1. v1.1-branch doesn't exists (https://github.com/kubeflow/website/branches/all?page=1).
  2. Master version of the website should always point to the master branch.

What do you think @Jeffwan @RFMVasconcelos ?

/cc @Bobgy @jlewi @8bitmp3

k8s-ci-robot pushed a commit to kubeflow/internal-acls that referenced this issue Nov 6, 2020
Adding permissions needed to create new branch -> see [v1.2 docs release issue](kubeflow/website#2322 (comment))
@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 7, 2020

@andreyvelich It's by design. see kubeflow/kubeflow#5371 (comment)

it's a little bit different from other projects. I think both solution work. website normally is changed frequently when user notice there's issue for latest branch. If we follow kubeflow/kubeflow way, then

  1. There will be lots of cherry-picks or user directly submit PR against v1.1-branch
  2. Kubeflow.org needs to switch to last stable version like v1.1 instead of master.

The v1.1 in banner doesn't mean there's a tag or version named v1.1. It's same as master. I know this is confuse, I think if most people want to do it in a different way, that works as well.

@jlewi
Copy link
Contributor

jlewi commented Nov 7, 2020

@Jeffwan is correct

  • We wait to cut the v1.1 docs branch because docs lag behind

  • We cut the v1.1 branch only when we are ready to start updating the docs for 1.2

    • We are probably at a point where people want to start committing 1.2 changes so cutting the 1.1 branch is a good idea
    • As @andreyvelich mentions we can cut the branch on a past commit if there have already been changes that are only relevant to 1.2
  • We can independently control whether www.kubeflow.org points to master or a 1.X branch

  • So after cutting 1.1 docs branch we should update www.kubeflow.org to point at 1.1

  • We can then develop 1.2 docs on master which will be available at master.kubeflow.org

  • When we are ready to release 1.2 we should flip www.kubeflow.org to point to the master branch containing 1.2 docs.

@rui-vas
Copy link
Contributor

rui-vas commented Nov 9, 2020

Sounds good @jlewi, @Jeffwan !

I am happy to make the v1.1-branch cut + redirect when we're ready.

@andreyvelich are there any merged docs that are v1.2 specific hence forcing a cut from a past commit? If not I'd rather do the cut at the current state.

The commit you mention is 1 month old, which means some relevant commits might be lost, including some of our recent efforts to remove "outdated" banners.

WDYT?

@andreyvelich
Copy link
Member

@RFMVasconcelos From AutoML WG only this commit is related to 1.2: 1df2cb9.

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 10, 2020

@RFMVasconcelos
image
I think this should be a safe commit?

I am not sure about #2327 that manifest change is not in 1.1-branch but master. @shawnzhu update KFDef to master which is fine for v1.1 users

It doesn't seem there're lots of updates from WG recently.

@rui-vas
Copy link
Contributor

rui-vas commented Nov 10, 2020

Ok @Jeffwan!

From the meeting, it seemed like nobody had big objections. I will use that commit and then ask the leads to review if there is any inconsistency on the v1.1-branch

@rui-vas
Copy link
Contributor

rui-vas commented Nov 11, 2020

Branch created -> https://github.com/kubeflow/website/tree/v1.1-branch

@rui-vas
Copy link
Contributor

rui-vas commented Nov 11, 2020

Netlify deployed v1.1 version:
https://v1-1-branch--competent-brattain-de2d6d.netlify.app/

@rui-vas
Copy link
Contributor

rui-vas commented Nov 11, 2020

Hey @jlewi @Bobgy, I've done steps 1 & 2 of the "Creating and publishing a website branch for vX.Y" guide. ☝️

I'm stuck on step 3, as I don't have access to the Cloud DNS of Kubeflow.org.

How should I proceed?

@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2020

One of @kubeflow/google-admins will have to do the DNS steps.

@rui-vas
Copy link
Contributor

rui-vas commented Nov 16, 2020

Thank you for clarifying @jlewi. Could any of the @kubeflow/google-admins provide a timeline for this?

Many thanks!

@Bobgy
Copy link
Contributor

Bobgy commented Nov 16, 2020

I'll take a look tomorrow

@Bobgy
Copy link
Contributor

Bobgy commented Nov 17, 2020

I've updated DNS record, https://v1-1-branch.kubeflow.org/ shows up correctly. It hasn't updated SSL certificate yet, I'm contacting netlify to set it up.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 17, 2020

After SSL ready, I'll do "Changing the version www.kubeflow.org points to" step

@rui-vas
Copy link
Contributor

rui-vas commented Nov 17, 2020

Awesome! Let me know if you want me to do any of the next steps

@Bobgy
Copy link
Contributor

Bobgy commented Nov 18, 2020

OK, SSL is now ready. I've also switched netlify to build v1.1-branch as kubeflow.org content.
@RFMVasconcelos can you continue to update master branch's label so it shows as v1.2

@rui-vas
Copy link
Contributor

rui-vas commented Nov 18, 2020

Hi @Bobgy!

Thank you for the help! I can take care of that until EOW

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 20, 2020

@RFMVasconcelos We cut code release. do you want to update the docs?

@rui-vas
Copy link
Contributor

rui-vas commented Nov 23, 2020

Hey @Jeffwan!

I have updated the website versioning -> #2365

Also opened issues for the following steps that are in the versioning guide:

@thesuperzapper
Copy link
Member

@RFMVasconcelos are you going to cut a 1.2 branch, rather than just pointing to master?

@Bobgy
Copy link
Contributor

Bobgy commented Dec 2, 2020

Shall we resolve the urgent issue first? We need to decide on a date when master will be shown as default for www.kubeflow.org instead of v1.1-branch.kubeflow.org.

Doc updates on GCP side is almost done, I have one last PR waiting to be merged.

@Bobgy
Copy link
Contributor

Bobgy commented Dec 2, 2020

/cc @Jeffwan
maybe you should make the call for "when we show 1.2 docs by default".

@rui-vas
Copy link
Contributor

rui-vas commented Dec 3, 2020

@thesuperzapper we're going to point to master.

It seems that we're only missing this step to update to v1.2.

I think we're ready to do this @Bobgy. I do not have access to Netlify, perhaps this needs to be done by a Googler?

@Bobgy
Copy link
Contributor

Bobgy commented Dec 4, 2020

GCP side is ready.

/cc @kubeflow/aws @kubeflow/arrikto @kubeflow/azure @Jeffwan @animeshsingh

Did I miss any stakeholders?

If no one raises an objection, I will switch doc to master next Tuesday.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 4, 2020

@Bobgy Double check with Seldon @cliveseldon and KFServing @andreyvelich

@animeshsingh Does IBM have a @kubeflow/ibm team handle? @Tomcli

@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 4, 2020

cc @kubeflow/wg-automl-leads @kubeflow/wg-notebook-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-training-leads @kubeflow/wg-serving-leads just to keep everyone in the loop

@andreyvelich
Copy link
Member

From AutoML WG all required docs were updated on November 14th.
That is the latest commit: b2ad541.

@Bobgy
Copy link
Contributor

Bobgy commented Dec 8, 2020

Updated default branch to master, once the next commit lands in master, the website will switch over to master as default.

@PatrickXYS
Copy link
Member

Update from AWS Side, we have updated our doc to v1.2

@rui-vas
Copy link
Contributor

rui-vas commented Dec 9, 2020

It seems that v1.2 docs are live!! 🚀

Thank you for the help @Bobgy!

/close

@k8s-ci-robot
Copy link
Contributor

@RFMVasconcelos: Closing this issue.

In response to this:

It seems that v1.2 docs are live!! 🚀

Thank you for the help @Bobgy!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants