-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Katib metric strategies info #2316
Add Katib metric strategies info #2316
Conversation
6927b20
to
4055a54
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is ready. |
@@ -64,14 +64,45 @@ These are the fields in the experiment configuration spec: | |||
how the hyperparameters work with the model. | |||
Katib records the value of the best `objectiveMetricName` metric (maximized | |||
or minimized based on `type`) and the corresponding hyperparameter set | |||
in Experiment's `.status.currentOptimalTrial.parameterAssignments`. | |||
in experiment's `.status.currentOptimalTrial.parameterAssignments`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in experiment's `.status.currentOptimalTrial.parameterAssignments`. | |
in the experiment's `.status.currentOptimalTrial.parameterAssignments`. |
- When the objective `type` is `minimize`, Katib compares all minimum | ||
metric values. | ||
|
||
You are able to change the default mechanism. For that, define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are able to change the default mechanism. For that, define | |
To change the default settings, define |
`additionalMetricNames`. The experiment's objective value is calculated in | ||
accordance with the selected strategy. | ||
|
||
For example, if you set the below parameters in your experiment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, if you set the below parameters in your experiment: | |
For example, you can set the parameters in your experiment as follows: |
. . . | ||
``` | ||
|
||
Katib controller is searching for the best maximum from the all latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Katib controller is searching for the best maximum from the all latest | |
where the Katib controller is searching for the best maximum from the all latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review @8bitmp3.
I made changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/lgtm
Fixes: kubeflow/katib#1310.
Blocked by: #2312.
I added doc about
metricStrategies
in Objective section./assign @johnugeorge @gaocegege
/cc @8bitmp3