Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS documentation to v1.2 #2391

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

PatrickXYS
Copy link
Member

On behalf of AWS, update AWS documentation to v1.2 in general

Help #2322

/cc @8bitmp3 @RFMVasconcelos

Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

assuming changing kfctl AWS YAML files to v1.2 from v1.1 is the only change in this PR

Thanks @PatrickXYS

@PatrickXYS
Copy link
Member Author

@8bitmp3 Right, that's minimal change I think

Seems like we need root owner to approve the PR

@Bobgy Can you help approve the PR?

Let me know if you think it's necessary to add OWNERS file in subfolder layouts, thus improve our bar of fine grained access.

@rui-vas
Copy link
Contributor

rui-vas commented Dec 4, 2020

Thank you for this update @PatrickXYS!

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Dec 5, 2020

Yes, please add OWNERS whenever you are updating anything aws specific

@Bobgy
Copy link
Contributor

Bobgy commented Dec 5, 2020

/lgtm
/approve
You can do that in a separate PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 8bitmp3, Bobgy, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 91407a3 into kubeflow:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants