Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix machinecontroller webhook escaping #2927

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix machinecontroller webhook escaping #2927

merged 1 commit into from
Oct 9, 2023

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 9, 2023

What this PR does / why we need it:
Add escaping of Registry name for the case when registry configured as wildcard.

Which issue(s) this PR fixes:

Fixes #2926

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add escaping of Registry name for the case when registry configured as wildcard.

Documentation:

NONE

@kron4eg
Fix machinecontroller webhook
fc35598 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 9, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kron4eg kron4eg marked this pull request as ready for review October 9, 2023 17:06
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 9, 2023
@kron4eg kron4eg requested a review from xmudrii October 9, 2023 18:09
xmudrii
xmudrii approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70b082abb1de9a4c6d7d7a451c1fda174e7f0a8e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@xmudrii
Copy link
Member

xmudrii commented Oct 9, 2023

/retest

@xmudrii
Copy link
Member

xmudrii commented Oct 9, 2023

/cherrypick release/v1.7 release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 release/v1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7 release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 6cff0af into kubermatic:main Oct 9, 2023
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Oct 9, 2023
@kubermatic-bot
Copy link
Contributor

@xmudrii: cannot checkout release/v1.7 release/v1.6: error checking out release/v1.7 release/v1.6: exit status 1. output: error: pathspec 'release/v1.7 release/v1.6' did not match any file(s) known to git

In response to this:

/cherrypick release/v1.7 release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Oct 9, 2023

/cherrypick release/v1.7

@xmudrii
Copy link
Member

xmudrii commented Oct 9, 2023

/cherrypick release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2928

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Oct 9, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2929

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Oct 9, 2023
Merged
@kron4eg kron4eg deleted the mc-webhook-registry branch October 10, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
3 participants
@kron4eg @kubermatic-bot @xmudrii