Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.7] Fix machinecontroller webhook escaping #2928

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[release/v1.7] Fix machinecontroller webhook escaping #2928

merged 1 commit into from
Oct 9, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #2927

/assign xmudrii

Add escaping of Registry name for the case when registry configured as wildcard.

@kron4eg
Fix machinecontroller webhook
df9de5f 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.7 milestone Oct 9, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 9, 2023
@kubermatic-bot kubermatic-bot mentioned this pull request Oct 9, 2023
Merged
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
xmudrii
xmudrii approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Oct 9, 2023
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 508b7a811e4a84737ed43f7b22db09f667278b63

@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 9, 2023
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Oct 9, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 9, 2023
@kubermatic-bot kubermatic-bot merged commit 3a96f52 into kubermatic:release/v1.7 Oct 9, 2023
13 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-2927-to-release/v1.7 branch October 9, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubermatic-bot @xmudrii @kron4eg