Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to cert-manager for certificates #1644

Merged
merged 1 commit into from
May 16, 2023
Merged

Switch to cert-manager for certificates #1644

merged 1 commit into from
May 16, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented May 16, 2023 •
edited
Loading

What this PR does / why we need it:
Use cert-manager for certificates for machine-controller webhooks.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] The default values for webhook flags `tls-cert-path` and `tls-key-path` have been changed to `/tmp/cert/tls.crt` and `/tmp/cert/tls.key` respectively. This is a result of updating it to use certificates generated from cert-manager.

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this May 16, 2023
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2023
@ahmedwaleedmalik
Switch to cert-manager for certificates
05437e0 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kron4eg
kron4eg requested changes May 16, 2023
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other then breaking CLI change, it looks good to me

cmd/webhook/main.go Show resolved Hide resolved
kron4eg
kron4eg approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f30e2339713cbeec4ad6619511220090d80ee30

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kron4eg
Copy link
Member

kron4eg commented May 16, 2023

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@kron4eg
Copy link
Member

kron4eg commented May 16, 2023

@ahmedwaleedmalik please update the release note with something like "BREAKING CLI change" explaining of what happened with those flags.

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2023
@ahmedwaleedmalik
Copy link
Member Author

@ahmedwaleedmalik please update the release note with something like "BREAKING CLI change" explaining of what happened with those flags.

@kron4eg updated PTAL

@kron4eg
Copy link
Member

kron4eg commented May 16, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f30e2339713cbeec4ad6619511220090d80ee30

@kubermatic-bot kubermatic-bot merged commit 8e58848 into kubermatic:main May 16, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request May 16, 2023
Merged
@embik embik mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg