-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fixes for examples with deprecated and changed flags #1655
Conversation
@frenchtoasters: Adding the "do-not-merge/docs-needed" label because no documentation block was detected, please follow our documentation process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: frenchtoasters The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @frenchtoasters. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: frenchtoasters <thedarkduck@gmail.com>
f5461ae
to
f017e69
Compare
/kind regression |
Hi @frenchtoasters, thank you for your contribution. Can you please specify what exactly is fixed by this PR, maybe by improving the description a bit? Updating |
Hey @embik the logging flags were removed because using the latest example from scratch those flags did not seem to work. I did see there were some other logging flags but I’m not that familiar with the project so wasn’t sure what a 1 to 1 replacement would be. |
Sorry for the late reply. I will check out your findings because this kind of confuses me, thanks for the additional details. |
Here are the errors that im seeing with the log flags
Then here is the logs for the webhook cert using the defaults just removing the bad log flags:
|
Hi @frenchtoasters - I finally figured out the issue here. The example manifest references the That is confusing and has sent you on the journey to change flags via this PR, however it will be resolved when we soon release a new version of machine-controller. In the mean time, I would recommend to use the example manifest from v1.56.2. Apologies for the confusion again, but I don't think we are going to move forward with this PR since a new release is imminent. |
Hi @frenchtoasters, as an update, we just released v1.57.0. This updated the |
I will close this PR as we didn't get a response and the issue this PR tried to solve should no longer be present. |
What this PR does / why we need it: This updates the
examples/machine-controller.yaml
to work with the latest changes.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind regression
Special notes for your reviewer: There might be other options that would be nice to have these are just want I had to change to get the deployments up and working.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: