Adding fixes for examples with deprecated and changed flags

[frenchtoasters]

What this PR does / why we need it: This updates the examples/machine-controller.yaml to work with the latest changes.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind regression

Special notes for your reviewer: There might be other options that would be nice to have these are just want I had to change to get the deployments up and working.

Does this PR introduce a user-facing change? Then add your Release Note here:

Documentation:

[kubermatic-bot]

@frenchtoasters: Adding the "do-not-merge/docs-needed" label because no documentation block was detected, please follow our documentation process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frenchtoasters
Once this PR has been reviewed and has the lgtm label, please assign kron4eg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubermatic-bot]

Hi @frenchtoasters. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frenchtoasters]

/kind regression

[embik]

Hi @frenchtoasters, thank you for your contribution.

Can you please specify what exactly is fixed by this PR, maybe by improving the description a bit? Updating --use-osm to --use-external-bootstrap makes sense to me (thank you for doing this; I overlooked that), but the PR also removes the logging flags introduced in #1606 (why?) and adds the certificate flag defaults as of #1644, so these changes and their motivation aren't fully clear to me.

[frenchtoasters]

Hi @frenchtoasters, thank you for your contribution.

Can you please specify what exactly is fixed by this PR, maybe by improving the description a bit? Updating --use-osm to --use-external-bootstrap makes sense to me (thank you for doing this; I overlooked that), but the PR also removes the logging flags introduced in #1606 (why?) and adds the certificate flag defaults as of #1644, so these changes and their motivation aren't fully clear to me.

Hey @embik the logging flags were removed because using the latest example from scratch those flags did not seem to work. I did see there were some other logging flags but I’m not that familiar with the project so wasn’t sure what a 1 to 1 replacement would be.
For the cert flags they needed to be changed because the secret that was created by default did not have the .pem file for the certs and to get the webhook pod up and running I had to add those.

[embik]

Sorry for the late reply. I will check out your findings because this kind of confuses me, thanks for the additional details.

[frenchtoasters]

Here are the errors that im seeing with the log flags

> k logs -n kube-system machine-controller-5dc6b8769d-bsx7c                                                                                 
flag provided but not defined: -log-debug

> k logs -n kube-system machine-controller-webhook-74754f547c-d9zhd
flag provided but not defined: -log-debug

> k logs -n kube-system machine-controller-8584b8f775-xm6bg 
flag provided but not defined: -log-format

> k logs -n kube-system machine-controller-webhook-75d7bb7fdb-gl6fb 
flag provided but not defined: -log-format

Then here is the logs for the webhook cert using the defaults just removing the bad log flags:

> k logs -n kube-system machine-controller-webhook-8676b8b5b9-gswzt 
W0613 19:50:10.071869       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This m
ight not work.
I0613 19:50:10.086980       1 plugin.go:95] looking for plugin "machine-controller-userdata-amzn2"
I0613 19:50:10.087059       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-amzn2'
I0613 19:50:10.087105       1 plugin.go:95] looking for plugin "machine-controller-userdata-centos"
I0613 19:50:10.087144       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-centos'
I0613 19:50:10.087183       1 plugin.go:95] looking for plugin "machine-controller-userdata-flatcar"
I0613 19:50:10.087219       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-flatcar'
I0613 19:50:10.087253       1 plugin.go:95] looking for plugin "machine-controller-userdata-rhel"
I0613 19:50:10.087288       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-rhel'
I0613 19:50:10.087323       1 plugin.go:95] looking for plugin "machine-controller-userdata-ubuntu"
I0613 19:50:10.087373       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-ubuntu'
I0613 19:50:10.087396       1 plugin.go:95] looking for plugin "machine-controller-userdata-rockylinux"
I0613 19:50:10.087455       1 plugin.go:136] found '/usr/local/bin/machine-controller-userdata-rockylinux'
F0613 19:50:10.087604       1 main.go:134] Failed to start server: open /tmp/cert/cert.pem: no such file or directory

[embik]

Hi @frenchtoasters - I finally figured out the issue here. The example manifest references the latest image tag, which points to the last released version (v1.56.2). Our main branch however has seen changes in flags that cause the issues you are running into. Essentially, the examples currently pass flags in a way that an unreleased version of machine-controller expects, but not the last released version (v1.56.2).

That is confusing and has sent you on the journey to change flags via this PR, however it will be resolved when we soon release a new version of machine-controller. In the mean time, I would recommend to use the example manifest from v1.56.2.

Apologies for the confusion again, but I don't think we are going to move forward with this PR since a new release is imminent.

[embik]

Hi @frenchtoasters, as an update, we just released v1.57.0. This updated the latest tag and means the examples should all work now and this PR is no longer needed. We are also tracking a split between user-facing and internal manifests in #1663. Would you agree we can close the PR?

[embik]

I will close this PR as we didn't get a response and the issue this PR tried to solve should no longer be present.