Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and logger for webhook #332

Merged
merged 11 commits into from
Dec 10, 2023
Merged

Update dependencies and logger for webhook #332

merged 11 commits into from
Dec 10, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Nov 24, 2023 •
edited

What this PR does / why we need it:
This PR does the following:

  1. Update dependencies
  2. Upgrade the base image to use alpine 3.18
  3. Upgrade to latest golangci-lint version
  4. Use zap instead of klog for webhook

Which issue(s) this PR fixes:

Fixes #293

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Logger for the webhook was switched from klog to zap, existing flags for configuring the logger, `-logtostderr`, `-v`, etc have been removed. Use `-log-debug=true/false` and `-log-format=text/json` instead.

Documentation:

NONE

@ahmedwaleedmalik
Update dependencies
b2dc628 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Update and fix build errors
ed802f7 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Use zap for logging instead of klog for webhook
c227808 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Fix import order
8fa9067 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Upgrade to latest golangci-lint
17bb28b 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Upgrade to alpine 3.18
a590811 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Fix panic with context
c9ba01c 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Update logger flags in manifests
56ed585 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 24, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2023
@ahmedwaleedmalik
Update generated code
218c142 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Refactored code
e6bfd1f 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 68c63c91f4a4862fafcf11fb2c184ea4e96793bc

xrstf
xrstf reviewed Nov 29, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ahmedwaleedmalik
Update go.mod
f659e08 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@xrstf
Copy link
Contributor

xrstf commented Nov 30, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d5b031470265c5ffec4e7ec6dc570a857c38bce

embik
embik approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@embik embik mentioned this pull request Dec 8, 2023
Merged
@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2023
@kubermatic-bot kubermatic-bot merged commit 28d391f into kubermatic:main Dec 10, 2023
11 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the updates branch December 10, 2023 20:34
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

@Waseem826 Waseem826 Awaiting requested review from Waseem826

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

@embik embik

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller-runtime v0.15 breaks the webhooks
5 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf @embik @Waseem826