Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zap instead of klog for controller #343

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Use zap instead of klog for controller #343

merged 1 commit into from
Jan 8, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Follow up for #332; use zap instead of klog for controller.

Which issue(s) this PR fixes:

Fixes #310

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Logger for the controller was switched from klog to zap, existing flags for configuring the logger, `-logtostderr`, `-v`, etc have been removed. Use `-log-debug=true/false` and `-log-format=text/json` instead.

Documentation:

NONE

@ahmedwaleedmalik
Use zap instead of klog for controller
10f7ae0 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jan 8, 2024
Merged
moelsayed
moelsayed approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@moelsayed moelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c101049b3933be0fb1908ddb13b408a939c6d11

@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@kubermatic-bot kubermatic-bot merged commit bd4e9f6 into kubermatic:main Jan 8, 2024
10 of 11 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the controller-logger branch January 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelsayed moelsayed moelsayed approved these changes

Assignees

@moelsayed moelsayed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs should include a human readable timestamp
3 participants
@ahmedwaleedmalik @kubermatic-bot @moelsayed