-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pod logs core api request errors. #227
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35170,7 +35170,7 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp | |
keyPairQuery_timestamps = keyValuePair_create(keyQuery_timestamps, valueQuery_timestamps); | ||
list_addElement(localVarQueryParameters,keyPairQuery_timestamps); | ||
} | ||
list_addElement(localVarHeaderType,"text/plain"); //produces | ||
//list_addElement(localVarHeaderType,"text/plain"); //produces removed text/plain as it is rejected | ||
list_addElement(localVarHeaderType,"application/json"); //produces | ||
list_addElement(localVarHeaderType,"application/yaml"); //produces | ||
list_addElement(localVarHeaderType,"application/vnd.kubernetes.protobuf"); //produces | ||
|
@@ -35193,9 +35193,11 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp | |
// printf("%s\n","Unauthorized"); | ||
//} | ||
//primitive return type simple | ||
char* elementToReturn = strdup((char*)apiClient->dataReceived); | ||
char* elementToReturn = NULL; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a good catch ! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR is for your reference: OpenAPITools/openapi-generator#17540 |
||
|
||
if (apiClient->dataReceived) { | ||
// moved strdup inside the guard to prevent segfaults on NULL dataReceived | ||
elementToReturn = strdup((char*)apiClient->dataReceived); | ||
free(apiClient->dataReceived); | ||
apiClient->dataReceived = NULL; | ||
apiClient->dataReceivedLen = 0; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't comment this line, will the result be correct? I don't think this should affect the results.
The
text/plain
header is defined in the Kubernetes OpenAPI spec. This line is automatically gnereated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that header is sent, it'll respond with a 400-level instead of a 200. The comment is needed to ensure that the header is not sent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll try this API.