-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for GHC 9.4 and enable GitHub Actions CI #104
Conversation
Hi @thomasjm. Thanks for your PR. I'm waiting for a kubernetes-client member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonschoning, thomasjm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thomasjm: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR builds on the great work by @peterbecich in #97 to update
kubernetes-client
so that it builds on the latest versions of GHC (up to and including9.4.5
).It also enables GitHub Actions, which is passing cleanly now as you can see here. I think there's a spurious failure with
8.10.7
; it works locally.This version includes both
attoparsec
andmegaparsec
as dependencies, becausejsonpath
switched from the former to the latter in version0.3.0.0
. We could lose a dependency by removingattoparsec
and dropping support for olderjsonpath
, but I think it's not a big deal since a) it's a fairly small dependency, b) it will be conditionally imported with CPP, so should not affect any final build products using this library, and c) it's nice to see all the green checkmarks in Github Actions CI for the different Stackage versions. But I don't feel too strongly about it.CC @akshaymankar and @jonschoning