-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #97
GitHub Actions #97
Conversation
Welcome @peterbecich! |
Hi @peterbecich. Thanks for your PR. I'm waiting for a kubernetes-client member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cool! I'd still suggest converting this to the Haskell setup actions -- the one I linked in the other discussion shows how to concisely test both Cabal and Stack. |
3ce7569
to
462083c
Compare
462083c
to
6fb4c8a
Compare
6fb4c8a
to
e46ec76
Compare
Let me know when this is ready for review! For now I'd suggest adding a few different Stack LTSes. |
@thomasjm yes, please review. I am trying to focus on the Cabal build. It appears to be failing on |
I tried building locally with cabal & ghc 9.4.4 and it couldn't satisfy all the constraints, perhaps we should exclude 9.4.4 from the matrix? Also, anything in |
Co-authored-by: Tom McLaughlin <pyro777@gmail.com>
Co-authored-by: Tom McLaughlin <pyro777@gmail.com>
b1000e4
to
19d4118
Compare
Thanks @jonschoning and @thomasjm Can we keep 9.4.4 in the build matrix, despite the failure, so that it exposes the issue and someone else might fix it? I will try to fix it myself, too. I've removed the change from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple formatting nits. Otherwise if the tests are running then LGTM!
.github/workflows/stack.yml
Outdated
fail-fast: false | ||
matrix: | ||
ghc: | ||
- "8.10.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: dedent these to be consistent with other list items in this file
.github/workflows/cabal.yml
Outdated
ghc: ['8.10.7', '9.0.2', '9.2.7', '9.4.4'] | ||
cabal: ['3.8.1.0'] | ||
os: [ubuntu-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: convert these to YAML-style lists (with -
) to be consistent with the Stack file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'd also suggest just combining the Cabal and Stack workflows into a single workflow file. That way you can see all the results in one page of GitHub Actions.
Co-authored-by: Tom McLaughlin <pyro777@gmail.com>
Good idea to combine the files. The tests are running: https://github.com/peterbecich/haskell-kubernetes-client/actions/runs/4395599081 The GHC 9.4 failure persists, I will try to fix that here: #101 |
Nice to see the Stack tests passing! It looks like all the Cabal ones are failing though? Do we need to pin the version of |
Just checking in here @peterbecich -- it looks like there was some progress on the Btw: GHC 9.4.5 is out and now on Stackage nightly, so maybe we should update these PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update 9.4.4
-> 9.4.5
in ci.yml
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: peterbecich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@peterbecich just checking in, any chance we can push this over the finish line? |
FWIW, I took your branch and made some more progress. Branch here: https://github.com/codedownio/kubernetes-client-haskell/tree/github-actions I'm stuck on an issue with |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This can be closed now with #104 landed. |
/close |
@jonschoning: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a GitHub Action for Cabal using https://github.com/haskell/actions/tree/main/setup#usage
The PR includes
cabal.project
to test all three projectsTest: #97 (comment)
Cabal build appears to be broken on
master
right now. I think it has something to do with https://hackage.haskell.org/package/hoauth2-2.6.0 Stack build succeeds. Please merge this and I will fix the Cabal build later.