GitHub Actions #97

peterbecich · 2023-02-15T06:05:47Z

This is a GitHub Action for Cabal using https://github.com/haskell/actions/tree/main/setup#usage
The PR includes cabal.project to test all three projects

Test: #97 (comment)

Cabal build appears to be broken on master right now. I think it has something to do with https://hackage.haskell.org/package/hoauth2-2.6.0 Stack build succeeds. Please merge this and I will fix the Cabal build later.

k8s-ci-robot · 2023-02-15T06:05:55Z

Welcome @peterbecich!

It looks like this is your first PR to kubernetes-client/haskell 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/haskell has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-02-15T06:05:56Z

Hi @peterbecich. Thanks for your PR.

I'm waiting for a kubernetes-client member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thomasjm · 2023-02-15T09:48:15Z

Cool! I'd still suggest converting this to the Haskell setup actions -- the one I linked in the other discussion shows how to concisely test both Cabal and Stack.

peterbecich · 2023-03-06T05:45:31Z

Test

Stack: https://github.com/peterbecich/haskell-kubernetes-client/actions/runs/4340317715/jobs/7578737597
Cabal: https://github.com/peterbecich/haskell-kubernetes-client/actions/runs/4340317722

thomasjm · 2023-03-08T23:53:18Z

Let me know when this is ready for review! For now I'd suggest adding a few different Stack LTSes.

peterbecich · 2023-03-09T01:22:09Z

@thomasjm yes, please review. I am trying to focus on the Cabal build. It appears to be failing on master right now. Having this new GitHub Action would be useful to fixing the Cabal build later, IMO. I don't have time to fix it right now in this PR.

jonschoning · 2023-03-09T01:40:15Z

I tried building locally with cabal & ghc 9.4.4 and it couldn't satisfy all the constraints, perhaps we should exclude 9.4.4 from the matrix?

Also, anything in kubernetes/ is going to get auto-generated and overwritten; the only thing we usually change is in kubernetes/kubernetes-client-core.cabal apart from running autogen is the package version. Any other changes in kubernetes/ should be upstreamed to https://github.com/OpenAPITools/openapi-generator/ so that the appropriate output is generated

kubernetes-client/package.yaml

.github/workflows/stack.yml

Co-authored-by: Tom McLaughlin <pyro777@gmail.com>

peterbecich · 2023-03-12T01:09:50Z

Thanks @jonschoning and @thomasjm

Can we keep 9.4.4 in the build matrix, despite the failure, so that it exposes the issue and someone else might fix it? I will try to fix it myself, too.

I've removed the change from kubernetes/

thomasjm

Just a couple formatting nits. Otherwise if the tests are running then LGTM!

thomasjm · 2023-03-12T02:36:43Z

.github/workflows/stack.yml

+      fail-fast: false
+      matrix:
+        ghc:
+          - "8.10.7"


Nit: dedent these to be consistent with other list items in this file

thomasjm · 2023-03-12T02:37:32Z

.github/workflows/cabal.yml

+        ghc: ['8.10.7', '9.0.2', '9.2.7', '9.4.4']
+        cabal: ['3.8.1.0']
+        os: [ubuntu-latest]


Nit: convert these to YAML-style lists (with -) to be consistent with the Stack file?

thomasjm

Oh, I'd also suggest just combining the Cabal and Stack workflows into a single workflow file. That way you can see all the results in one page of GitHub Actions.

.github/workflows/stack.yml

Co-authored-by: Tom McLaughlin <pyro777@gmail.com>

peterbecich · 2023-03-12T03:46:15Z

Good idea to combine the files. The tests are running: https://github.com/peterbecich/haskell-kubernetes-client/actions/runs/4395599081

The GHC 9.4 failure persists, I will try to fix that here: #101

thomasjm · 2023-03-14T00:23:02Z

Nice to see the Stack tests passing! It looks like all the Cabal ones are failing though? Do we need to pin the version of hoauth2 better in the Cabal case?

thomasjm · 2023-05-10T21:19:16Z

Just checking in here @peterbecich -- it looks like there was some progress on the hoauth2 situation mentioned in #101. Any chance this will fix the Cabal builds? It would be cool to get this (and #101) merged.

Btw: GHC 9.4.5 is out and now on Stackage nightly, so maybe we should update these PRs?

thomasjm

Please update 9.4.4 -> 9.4.5 in ci.yml

k8s-ci-robot · 2023-05-10T21:20:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peterbecich
Once this PR has been reviewed and has the lgtm label, please assign akshaymankar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thomasjm · 2023-06-22T23:47:47Z

@peterbecich just checking in, any chance we can push this over the finish line?

thomasjm · 2023-06-23T05:16:28Z

FWIW, I took your branch and made some more progress. Branch here:

https://github.com/codedownio/kubernetes-client-haskell/tree/github-actions

I'm stuck on an issue with jsonpath-0.3.0.0, filed a help request here:

akshaymankar/jsonpath-hs#37

k8s-ci-robot · 2023-07-05T07:34:23Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thomasjm · 2023-07-05T07:39:16Z

This can be closed now with #104 landed.

jonschoning · 2023-07-05T14:26:54Z

/close

k8s-ci-robot · 2023-07-05T14:26:57Z

@jonschoning: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from brendandburns and jonschoning February 15, 2023 06:05

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 15, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2023

peterbecich mentioned this pull request Feb 15, 2023

GitHub Action generated with haskell-ci codedownio/kubernetes-client-haskell#1

Closed

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2023

peterbecich force-pushed the github-actions branch 2 times, most recently from 3ce7569 to 462083c Compare March 6, 2023 04:29

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2023

peterbecich force-pushed the github-actions branch from 462083c to 6fb4c8a Compare March 6, 2023 04:41

peterbecich added 4 commits March 5, 2023 21:35

GitHub Action generated with https://github.com/haskell-CI/haskell-ci

befdb93

build-tool-depends

163079c

fix cabal check

2b56c7e

use https://github.com/haskell/actions/tree/main/setup

e46ec76

peterbecich force-pushed the github-actions branch from 6fb4c8a to e46ec76 Compare March 6, 2023 05:35

test GHC 8.10.7

b44ea56

thomasjm suggested changes Mar 9, 2023

View reviewed changes

kubernetes-client/package.yaml Outdated Show resolved Hide resolved

.github/workflows/stack.yml Outdated Show resolved Hide resolved

.github/workflows/stack.yml Outdated Show resolved Hide resolved

peterbecich and others added 3 commits March 11, 2023 16:58

Update .github/workflows/stack.yml

af3b6df

Co-authored-by: Tom McLaughlin <pyro777@gmail.com>

Update .github/workflows/stack.yml

fbcfb3a

Co-authored-by: Tom McLaughlin <pyro777@gmail.com>

remove tested-with

19d4118

peterbecich force-pushed the github-actions branch from b1000e4 to 19d4118 Compare March 12, 2023 01:06

peterbecich requested review from thomasjm and removed request for jonschoning and brendandburns March 12, 2023 01:10

thomasjm approved these changes Mar 12, 2023

View reviewed changes

thomasjm reviewed Mar 12, 2023

View reviewed changes

.github/workflows/stack.yml Outdated Show resolved Hide resolved

peterbecich and others added 2 commits March 11, 2023 19:32

Update .github/workflows/stack.yml

da610c6

Co-authored-by: Tom McLaughlin <pyro777@gmail.com>

combine CI yamls

8d0c1bd

peterbecich requested a review from thomasjm March 12, 2023 03:50

thomasjm suggested changes May 10, 2023

View reviewed changes

thomasjm mentioned this pull request Jun 27, 2023

Fix build for GHC 9.4 and enable GitHub Actions CI #104

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2023

k8s-ci-robot closed this Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Actions #97

GitHub Actions #97

peterbecich commented Feb 15, 2023 •

edited

Loading

k8s-ci-robot commented Feb 15, 2023

k8s-ci-robot commented Feb 15, 2023

thomasjm commented Feb 15, 2023

peterbecich commented Mar 6, 2023

thomasjm commented Mar 8, 2023

peterbecich commented Mar 9, 2023

jonschoning commented Mar 9, 2023 •

edited

Loading

peterbecich commented Mar 12, 2023

thomasjm left a comment

thomasjm Mar 12, 2023

thomasjm Mar 12, 2023

thomasjm left a comment

peterbecich commented Mar 12, 2023

thomasjm commented Mar 14, 2023

thomasjm commented May 10, 2023

thomasjm left a comment

k8s-ci-robot commented May 10, 2023

thomasjm commented Jun 22, 2023

thomasjm commented Jun 23, 2023

k8s-ci-robot commented Jul 5, 2023

thomasjm commented Jul 5, 2023

jonschoning commented Jul 5, 2023

k8s-ci-robot commented Jul 5, 2023

GitHub Actions #97

GitHub Actions #97

Conversation

peterbecich commented Feb 15, 2023 • edited Loading

k8s-ci-robot commented Feb 15, 2023

k8s-ci-robot commented Feb 15, 2023

thomasjm commented Feb 15, 2023

peterbecich commented Mar 6, 2023

thomasjm commented Mar 8, 2023

peterbecich commented Mar 9, 2023

jonschoning commented Mar 9, 2023 • edited Loading

peterbecich commented Mar 12, 2023

thomasjm left a comment

Choose a reason for hiding this comment

thomasjm Mar 12, 2023

Choose a reason for hiding this comment

thomasjm Mar 12, 2023

Choose a reason for hiding this comment

thomasjm left a comment

Choose a reason for hiding this comment

peterbecich commented Mar 12, 2023

thomasjm commented Mar 14, 2023

thomasjm commented May 10, 2023

thomasjm left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 10, 2023

thomasjm commented Jun 22, 2023

thomasjm commented Jun 23, 2023

k8s-ci-robot commented Jul 5, 2023

thomasjm commented Jul 5, 2023

jonschoning commented Jul 5, 2023

k8s-ci-robot commented Jul 5, 2023

peterbecich commented Feb 15, 2023 •

edited

Loading

jonschoning commented Mar 9, 2023 •

edited

Loading