-
Notifications
You must be signed in to change notification settings - Fork 185
Bugfix Azure AD auth config field 'expired-on': checking an int against time.struct_time #121
Conversation
Compare two time.struct_time objects instead of an int and a time.struct_time, which will throw a TypeError exception.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lbach If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am having some issues registering with LinuxFoundation. I'll have the CLA signed once I get my account with LinuxFoundation sorted. |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 92.11% 91.88% -0.23%
==========================================
Files 13 13
Lines 1217 1220 +3
==========================================
Hits 1121 1121
- Misses 96 99 +3
Continue to review full report at Codecov.
|
There's an issue with this patch. When applied, I get the following exception:
|
I'm new at this whole github contributing thing, but if you change the
Credit to @fatal-exception in #84 |
@lbach Any chance this can be finished? It'd be a huge help to us to have this working. Thanks! |
Verified this is broken in |
@lbach: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the verification! We are working on releasing 11.0.0 GA. I added an item in the bi-weekly meeting agenda. cc @palnabarun |
Compare two time.struct_time objects instead of an int and a
time.struct_time, which will throw a TypeError exception.
This fixes #84
This pull request is to #85 but this is an effort to revive the fix.