Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Fix issue 84: Update _load_azure_token to hande str and int #141

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

rogerhmar
Copy link
Contributor

Fix bug by first checking if it is a digit

Add tests for:

  • time str
  • int
  • illegal str
  • illegal int

There were several pull requests on this, but none seem to have tests.

This should fix #84

@k8s-ci-robot
Copy link
Contributor

Welcome @rogerhmar!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2019
@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.58%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   92.86%   93.44%   +0.58%     
==========================================
  Files          13       13              
  Lines        1345     1374      +29     
==========================================
+ Hits         1249     1284      +35     
+ Misses         96       90       -6
Impacted Files Coverage Δ
config/kube_config_test.py 95.19% <100%> (+0.25%) ⬆️
config/kube_config.py 88.15% <85.71%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474e9fb...6edea7b. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2019
@rogerhmar
Copy link
Contributor Author

@roycaihw and @yliaog: Do you have the time to look at this?

@yliaog
Copy link
Contributor

yliaog commented Jul 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rogerhmar, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 95858d5 into kubernetes-client:master Jul 8, 2019
@rogerhmar rogerhmar deleted the fix_issue_84 branch July 9, 2019 18:21
@Sephtex
Copy link

Sephtex commented Jul 10, 2019

For which version of the kubernetes pip package will this fix be available? I need the openshift-0.9.0 package which I have installed and it has kubernetes-9.0.0 as dependency. I updated kubernetes to v10.0.0 and I couldn't find the fix yet. I suppose this fix will land in 9.0.0?

@yliaog
Copy link
Contributor

yliaog commented Jul 10, 2019

it will land in the next release. the current release is v10.0.0. so v11.0.0 should have it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
5 participants