Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Update _load_azure_token #134

Closed
wants to merge 1 commit into from
Closed

Update _load_azure_token #134

wants to merge 1 commit into from

Conversation

rabidang3ls
Copy link

@rabidang3ls rabidang3ls commented May 13, 2019

_load_azure_token would fail if the "expires-on" field was not comprised of digits. The field isn't guaranteed to be digits, so this updates the code to also accept the date format `%Y-%m-%d %H:%M:%S.%f

FIx for #84

_load_azure_token would fail if the "expires-on" field was not comprised of digits. The field isn't guaranteed to be digits, so this updates the code to also accept the date format `%Y-%m-%d %H:%M:%S.%f`
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rabidang3ls
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yliaog

If they are not already assigned, you can assign the PR to them by writing /assign @yliaog in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bitsofinfo
Copy link

@rabidang3ls whats the status of this? really need it! thank you

@rabidang3ls
Copy link
Author

@bitsofinfo I don't know the project well enough to understand their travis-ci output. Not sure what fails, but I haven't had any issues with it. Looks like #141 passed all checks and should be implementing the same fix.

@rabidang3ls rabidang3ls closed this Jul 8, 2019
@rabidang3ls rabidang3ls deleted the patch-1 branch July 8, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants