Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add property returncode to WSClient #160

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Sep 17, 2019

This will be familiar for Python users as subprocess.Popen has
the same attribute. Also, the behavior is such the returncode returns
a None value if the process was not run yet.

Other than that, when the process exists with a numerical code this will
be the value of the return code. If the command executed successfully
the return value will be 0.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2019
This will be familiar for Python users as subprocess.Popen has
the same attribute. Also, the behavior is such the returncode returns
a None value if the process was not run yet.

Other than that, when the process exists with a numerical code this will
be the value of the return code. If the command executed successfully
the return value will be 0.
@codecov-io
Copy link

Codecov Report

Merging #160 into master will decrease coverage by 83.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #160      +/-   ##
=========================================
- Coverage   93.56%   9.97%   -83.6%     
=========================================
  Files          13      13              
  Lines        1384    1384              
=========================================
- Hits         1295     138    -1157     
- Misses         89    1246    +1157
Impacted Files Coverage Δ
config/dateutil_test.py 0% <0%> (-100%) ⬇️
watch/watch_test.py 0% <0%> (-98.71%) ⬇️
config/exec_provider_test.py 0% <0%> (-98.39%) ⬇️
config/incluster_config_test.py 0% <0%> (-97.3%) ⬇️
config/kube_config_test.py 0% <0%> (-95.2%) ⬇️
watch/watch.py 20.48% <0%> (-79.52%) ⬇️
config/kube_config.py 20% <0%> (-68.16%) ⬇️
config/exec_provider.py 17.39% <0%> (-65.22%) ⬇️
config/dateutil.py 35.41% <0%> (-60.42%) ⬇️
config/incluster_config.py 29.78% <0%> (-55.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1ab55...69570ac. Read the comment docs.

@roycaihw
Copy link
Member

/assign

@roycaihw
Copy link
Member

/lgtm
/approve

Thanks for having it e2e tested in kubernetes-client/python#956!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5092d96 into kubernetes-client:master Sep 18, 2019
@oz123 oz123 deleted the exit_code branch October 2, 2019 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants