Test getting the returncode of execution in a pod #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/assign |
roycaihw
reviewed
Sep 18, 2019
oz123
force-pushed
the
get_exit_code
branch
from
a4b76ff
to
1d68151
Compare
This tests demonstrate how to execute a command in a pod and what behavior is expected. As discussed in the commit bf367ed6ddc63369f76df0a07b248a6711328605 in python-base this behavior would be familiar to Python users, as `subprocess.Popen` has the same property.
oz123
force-pushed
the
get_exit_code
branch
from
1d68151
to
752373b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oz123, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests demonstrate how to execute a command in a pod and
what behavior is expected. As discussed in the commit
kubernetes-client/python-base@bf367ed in python-base this
behavior would be familiar to Python users, as
subprocess.Popenhas the same property.
Also, it's worth mentioning #812 which this PR is a suggested fix for.