Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add tests of unmarshaling literals to watch.py #174

Closed
wants to merge 1 commit into from
Closed

Add tests of unmarshaling literals to watch.py #174

wants to merge 1 commit into from

Conversation

jiahuif
Copy link

@jiahuif jiahuif commented Oct 23, 2019

@k8s-ci-robot
Copy link
Contributor

Welcome @jiahuif!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiahuif
To complete the pull request process, please assign yliaog
You can assign the PR to them by writing /assign @yliaog in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2019
@jiahuif jiahuif force-pushed the test-watch-unmarshal branch 2 times, most recently from 758d55e to ac4781e Compare October 23, 2019 19:14
@jiahuif
Copy link
Author

jiahuif commented Oct 23, 2019

/cc @roycaihw
Failing tests is intended as we are adding tests to reveal a bug.

roycaihw
roycaihw reviewed Oct 24, 2019
View reviewed changes
watch/watch_test.py
@@ -250,6 +250,24 @@ def test_unmarshal_with_custom_object(self):
self.assertEqual("1", event['object']['metadata']['resourceVersion'])
self.assertEqual("1", w.resource_version)

# ref: gh-982
def test_unmarshal_with_object_literal(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the tests submitted with the fix?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2020
@roycaihw
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2020
@roycaihw roycaihw mentioned this pull request Feb 13, 2020
Closed
@roycaihw
Copy link
Member

/close
in favor of #185

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closed this PR.

In response to this:

/close
in favor of #185

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roycaihw roycaihw roycaihw left review comments

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jiahuif @k8s-ci-robot @fejta-bot @roycaihw