-
Notifications
You must be signed in to change notification settings - Fork 185
Add tests of unmarshaling literals to watch.py #174
Conversation
Welcome @jiahuif! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiahuif The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
758d55e
to
ac4781e
Compare
ac4781e
to
8d063b2
Compare
/cc @roycaihw |
@@ -250,6 +250,24 @@ def test_unmarshal_with_custom_object(self): | |||
self.assertEqual("1", event['object']['metadata']['resourceVersion']) | |||
self.assertEqual("1", w.resource_version) | |||
|
|||
# ref: gh-982 | |||
def test_unmarshal_with_object_literal(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have the tests submitted with the fix?
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/close |
@roycaihw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
see #171
see kubernetes-client/python#982
see kubernetes-client/python#983