-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to get a log stream when log line is json type #982
Comments
I checked fix like below. But this is a bad solution.
|
/assign |
@Ark-kun
I think https://github.com/Ark-kun/python-base/commit/f11587d0e3cedf645ba12fe4dfd7971ee7162c9d is not a fundamental solution. |
Unfortunately, the fundamental solution might not exist. dictionaries duck typed by design. You cannot type-check them. The code in question decided to do some transformation of the |
Maybe we should just disable unmarshalling for logs. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@roycaihw: GitHub didn't allow me to assign the following users: jiahuif. Note that only kubernetes-client members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
That is good enough to give me a ping. Let me recall the context. |
What happened (please include outputs or screenshots):
When I got log like blow (use stream)
Error occured like below
What you expected to happen:
Get a logs without error
How to reproduce it (as minimally and precisely as possible):
Try to get json type log like this
Anything else we need to know?:
Environment:
kubectl version
): 1.15python --version
) : Python 3.7.3pip list | grep kubernetes
) : 10.0.1The text was updated successfully, but these errors were encountered: