Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Run scripts/update-pycodestyle.sh to fix the pycodestyle test failure #200

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Run scripts/update-pycodestyle.sh to fix the pycodestyle test failure #200

merged 1 commit into from
Jun 22, 2020

Conversation

roycaihw
Copy link
Member

Due to the issue with travis not reporting job result back, #195 was merged with a pycodestyle test failure.

This PR runs scripts/update-pycodestyle.sh to fix the test.

/cc @palnabarun @vishnu667

@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: vishnu667.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Due to the issue with travis not reporting job result back, #195 was merged with a pycodestyle test failure.

This PR runs scripts/update-pycodestyle.sh to fix the test.

/cc @palnabarun @vishnu667

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2020
@roycaihw
Copy link
Member Author

roycaihw commented Jun 22, 2020 •
edited

/hold

until the travis job succeeds

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@roycaihw roycaihw mentioned this pull request Jun 22, 2020
Merged
@micw523
Copy link
Contributor

micw523 commented Jun 22, 2020

Looks like it will be fine
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@roycaihw
Copy link
Member Author

/hold cancel

https://travis-ci.org/github/kubernetes-client/python-base/builds/701073102

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 70d6639 into kubernetes-client:master Jun 22, 2020
@roycaihw roycaihw deleted the fix/pycodestyle branch June 22, 2020 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@micw523 micw523

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roycaihw @k8s-ci-robot @micw523