-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenAPI generator and the client #1188
Update OpenAPI generator and the client #1188
Conversation
6e0c532
to
5240b76
Compare
There is a test failure in the base submodule:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits LGTM in general. Once we collect the API change caused by openapi-generator in CHANGELOG we will be good to go.
@@ -1,39 +0,0 @@ | |||
# coding: utf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream issue: OpenAPITools/openapi-generator#5377
I checked python-base and found there was one pycodestyle failure merged accidentally. I sent a fix: kubernetes-client/python-base#200. The error in #1188 (comment) looks different though. I created an experimental PR #1191 that only bumps python-base, to help us better identify if the bug is on our side or introduced by openapi-generator. |
The tests passed in #1191. Looks like the |
The test failure
is related to the upstream change OpenAPITools/openapi-generator#4988. In the test we faked a Configuration with a customized |
/reopen (the bot mistakenly closed this due to kubernetes-client/python-base#202 merging) |
@palnabarun: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Reference: OpenAPITools/openapi-generator#5377 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
The upstream 1.16 API moved ahead due to [patch releases](https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md). The logs are gathered from the upstream [CHANGELOG](https://raw.githubusercontent.com/kubernetes/kubernetes/master/CHANGELOG/CHANGELOG-1.16.md). Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Reference: - [kubernetes-client#866](kubernetes-client#866) - [kubernetes-client#959](kubernetes-client#959) Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Reference: kubernetes-client#974 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
fc74c0a
to
259e640
Compare
The build is again failing due to a regression caused in kubernetes-client/python-base#133. Ref: https://travis-ci.org/github/kubernetes-client/python-base/builds/708448505 |
kubernetes-client/python-base#204 will fix the test failure. |
259e640
to
9a20c56
Compare
After kubernetes-client/python-base#204 got merged, the tests are passing. |
CHANGELOG.md
Outdated
- Allow incluster to accept pass-in config [kubernetes-client/python-base#193](https://github.com/kubernetes-client/python-base/pull/193) | ||
- Set expiration on token of incluster config and reload the token if it expires [kubernetes-client/python-base#191](https://github.com/kubernetes-client/python-base/pull/191) | ||
|
||
**Bug Fix:** | ||
|
||
- Fixes a bug in loading kubeconfig when there are no users in ttthe config [kubernetes-client/python-base#198](https://github.com/kubernetes-client/python-base/pull/198) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo ttthe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch. 👍 It is resolved now.
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
The changes have been listed in the CHANGELOG and linked to the respective milestone pull requests. Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
616e40d
to
08ed6c2
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR also:
Follow ups: