Release 12.0.0a1 #1130
Release 12.0.0a1 #1130
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: scottilee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
| @@ -3887,7 +3887,7 @@ def patch_namespaced_deployment_with_http_info(self, name, namespace, body, **kw | |||
|
|
|||
| # HTTP header `Content-Type` | |||
| header_params['Content-Type'] = self.api_client.select_header_content_type( # noqa: E501 | |||
| ['application/json-patch+json', 'application/merge-patch+json', 'application/strategic-merge-patch+json']) # noqa: E501 | |||
| ['application/json-patch+json', 'application/merge-patch+json', 'application/strategic-merge-patch+json', 'application/apply-patch+yaml']) # noqa: E501 | |||
There was a problem hiding this comment.
Hi. I have K8S 1.16. I noticed one interesting bug. If I call patch_namespaced_deployment through the client to DELETE 1 or more environment variables, then the request is successful, however, the deployment itself is not updated.
After a little research, I found out that the select_header_content_type method called here returns just the 1st element of this array. I also found out that if you put the 2nd element of an array in the header, then the deployment is updated perfectly.
| ['application/json-patch+json', 'application/merge-patch+json', 'application/strategic-merge-patch+json', 'application/apply-patch+yaml']) # noqa: E501 | |
| ['application/merge-patch+json', 'application/json-patch+json', 'application/strategic-merge-patch+json', 'application/apply-patch+yaml']) # noqa: E501 |
|
|
||
| # client version for packaging and releasing. | ||
| CLIENT_VERSION = "11.0.0-snapshot" | ||
| CLIENT_VERSION = "12.0.0a1" |
There was a problem hiding this comment.
This PR targets the master branch. I think we should first generates a 12.0.0-snapshot client in the master branch with API changes from upstream release-1.16. Then generates a 12.0.0a1 client in the release-12.0 branch with only version constant changes.
| **Deprecation Notice** | ||
| v12.0.0 of the client follows the Kubernetes [deprecation policy](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/release/versioning.md#supported-releases-and-component-skew) and will | ||
| be deprecated as and when Kubernetes version v1.16 gets deprecated. | ||
|
|
There was a problem hiding this comment.
Could you add CHANGELOG about the API changes generated?
|
Will open a new PR when #1141 merges. |
Release 12.0.0a1 introduces several changes and is compatible with Kubernetes v1.16.
[x] Updated the constants version
[x] Generated client changes
[x] Applied hotfixes
[x] Updated python-base submodules
[x] Updated the CHANGELOG
Fixes #1052