-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on 32bit #320
Fix build on 32bit #320
Conversation
The constant math.MaxUint32 has no type specified. Golang tries to cast it to int, which crashes the assembly on 32 bit architectures.
Welcome @c0va23! |
Hi @c0va23. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm Needs to be approved by someone from csi-driver-host-path/release-tools/KUBERNETES_CSI_OWNERS_ALIASES Lines 7 to 11 in 22c659d
|
/assign @saad-ali |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c0va23, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The constant math.MaxUint32 has no type specified. Golang tries to cast
it to int, which crashes the assembly on 32 bit architectures.
Steps to reproduce on the current master:
Which issue(s) this PR fixes:
Fixes kubernetes-csi/csi-release-tools#167
Special notes for your reviewer:
I want to get a build of images for armv7 architecture. This change should fix the build of this PR kubernetes-csi/node-driver-registrar#161
Does this PR introduce a user-facing change?: