Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on 32bit #320

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fix build on 32bit #320

merged 1 commit into from
Aug 12, 2021

Conversation

c0va23
Copy link
Contributor

@c0va23 c0va23 commented Aug 11, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

The constant math.MaxUint32 has no type specified. Golang tries to cast
it to int, which crashes the assembly on 32 bit architectures.

Steps to reproduce on the current master:

$ GOARCH=386 go build ./cmd/hostpathplugin/main.go
# github.com/kubernetes-csi/csi-driver-host-path/pkg/hostpath
pkg/hostpath/controllerserver.go:663:5: constant 4294967295 overflows int

$ GOARCH=arm go build ./cmd/hostpathplugin/main.go
# github.com/kubernetes-csi/csi-driver-host-path/pkg/hostpath
pkg/hostpath/controllerserver.go:663:5: constant 4294967295 overflows int

Which issue(s) this PR fixes:

Fixes kubernetes-csi/csi-release-tools#167

Special notes for your reviewer:

I want to get a build of images for armv7 architecture. This change should fix the build of this PR kubernetes-csi/node-driver-registrar#161

Does this PR introduce a user-facing change?:

Fix build on 32bit platforms

The constant math.MaxUint32 has no type specified. Golang tries to cast
it to int, which crashes the assembly on 32 bit architectures.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @c0va23!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @c0va23. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2021
@mauriciopoppe
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2021
@mauriciopoppe
Copy link
Member

/lgtm

Needs to be approved by someone from

kubernetes-csi-approvers:
- jsafrane
- msau42
- saad-ali
- xing-yang
too

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 12, 2021

/assign @saad-ali

@pohly
Copy link
Contributor

pohly commented Aug 12, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c0va23, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86b9bd6 into kubernetes-csi:master Aug 12, 2021
@c0va23 c0va23 deleted the fix/build-on-32bit branch August 12, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants