Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform linux/arm #161

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Add platform linux/arm #161

merged 2 commits into from
Aug 17, 2021

Conversation

c0va23
Copy link
Contributor

@c0va23 c0va23 commented Aug 10, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

democratic-csi has builds for linux/arm, but that doesn't work out of the box because node-driver-registrar does not provide images for this architecture. Currently, to use democratic-csi and other CSI drivers on the linux/arm platform, you have to use third-party node-driver-registrar builds.

I understand that the linux/arm platform can hardly be called complete for server applications. But first, we have official K8S builds for this platform. Secondly, nodes with such a platform can be used for native CI/CD for low-power devices on linux/arm.

In my case, I use RPI4 with 32 bit Ubuntu to build a compact multimedia server that can be operated on low-power devices.

Which issue(s) this PR fixes:

Fixes #150

Special notes for your reviewer:

linux/arm image tested on RPI4 with host OS Ubuntu 20.04.2 (32bit, https://cdimage.ubuntu.com/releases/20.04.2/release/ubuntu-20.04.2-preinstalled-server-armhf+raspi.img.xz). I tested "node-driver-registrar" with democratic-csi (https://github.com/democratic-csi/democratic-csi) as a volume provider for the Drone CI Kubernetes Runner (https://github.com/drone-runners/drone-runner-kube). The linux/arm build works the same as the linux/amd64 and linux/arm64 builds.

For testing, I created a temporary image for all linux architectures (including arm), which I placed here https://github.com/c0va23/node-driver-registrar/pkgs/container/csi-node-driver-registrar.

Does this PR introduce a user-facing change?:

Added `linux/arm` platform for multiarch image 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @c0va23!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @c0va23. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 10, 2021

/assign @c0va23

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Aug 10, 2021

the folder release-tools comes as a git subtree from https://github.com/kubernetes-csi/csi-release-tools, this PR should probably be there too instead

@msau42
Copy link
Collaborator

msau42 commented Aug 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 10, 2021

@mauriciopoppe, thanks for the hint. I will push the changes to the upstream release-tools and push their ships when the changes are merged.

@c0va23
Copy link
Contributor Author

c0va23 commented Aug 10, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2021
@c0va23 c0va23 changed the title Add platform linux/arm [WIP] Add platform linux/arm Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 10, 2021

Port changes to kubernetes-csi/csi-release-tools#167

c0va23 added 2 commits August 17, 2021 17:58
0438f15a Merge pull request #167 from c0va23/feature/release-armv7-image
4786f4d0 Merge pull request #168 from msau42/update-release-prereq
6a2dc64a Remove requirement to be top-level approver. Only maintainers membership is required to do a release
30a4f7bb Release armv7 image
ac8108f1 Merge pull request #165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD
999b483d docs: make github links reference HEAD instead of main
fd670693 docs: make github links reference HEAD instead of master

git-subtree-dir: release-tools
git-subtree-split: 0438f15a319d0c08bc1a82adf60c3e2ea02760ce
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2021
@c0va23 c0va23 changed the title [WIP] Add platform linux/arm Add platform linux/arm Aug 17, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 17, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@c0va23
Copy link
Contributor Author

c0va23 commented Aug 17, 2021

Update release-tools from csi-release-tools from upstream

@mauriciopoppe
Copy link
Member

I saw that the build logs are ok, thanks for adding 32 bit arm support to CSI!
/lgtm
/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 August 17, 2021 17:35
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@msau42
Copy link
Collaborator

msau42 commented Aug 17, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c0va23, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 751205b into kubernetes-csi:master Aug 17, 2021
@c0va23 c0va23 deleted the feature/arm32 branch August 17, 2021 18:45
@andyzhangx
Copy link
Member

so next release v2.4.0 would have arm/v7 support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARM (armv7) images
5 participants