-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform linux/arm #161
Conversation
Welcome @c0va23! |
Hi @c0va23. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @c0va23 |
the folder |
/ok-to-test |
@mauriciopoppe, thanks for the hint. I will push the changes to the upstream release-tools and push their ships when the changes are merged. |
/hold |
Port changes to kubernetes-csi/csi-release-tools#167 |
0438f15a Merge pull request #167 from c0va23/feature/release-armv7-image 4786f4d0 Merge pull request #168 from msau42/update-release-prereq 6a2dc64a Remove requirement to be top-level approver. Only maintainers membership is required to do a release 30a4f7bb Release armv7 image ac8108f1 Merge pull request #165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD 999b483d docs: make github links reference HEAD instead of main fd670693 docs: make github links reference HEAD instead of master git-subtree-dir: release-tools git-subtree-split: 0438f15a319d0c08bc1a82adf60c3e2ea02760ce
/unhold |
Update release-tools from csi-release-tools from upstream |
I saw that the build logs are ok, thanks for adding 32 bit arm support to CSI! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c0va23, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
so next release |
What type of PR is this?
/kind feature
What this PR does / why we need it:
democratic-csi
has builds forlinux/arm
, but that doesn't work out of the box becausenode-driver-registrar
does not provide images for this architecture. Currently, to usedemocratic-csi
and other CSI drivers on thelinux/arm
platform, you have to use third-partynode-driver-registrar
builds.I understand that the
linux/arm
platform can hardly be called complete for server applications. But first, we have official K8S builds for this platform. Secondly, nodes with such a platform can be used for native CI/CD for low-power devices onlinux/arm
.In my case, I use RPI4 with 32 bit Ubuntu to build a compact multimedia server that can be operated on low-power devices.
Which issue(s) this PR fixes:
Fixes #150
Special notes for your reviewer:
linux/arm
image tested on RPI4 with host OS Ubuntu 20.04.2 (32bit, https://cdimage.ubuntu.com/releases/20.04.2/release/ubuntu-20.04.2-preinstalled-server-armhf+raspi.img.xz). I tested "node-driver-registrar" with democratic-csi (https://github.com/democratic-csi/democratic-csi) as a volume provider for the Drone CI Kubernetes Runner (https://github.com/drone-runners/drone-runner-kube). Thelinux/arm
build works the same as thelinux/amd64
andlinux/arm64
builds.For testing, I created a temporary image for all linux architectures (including arm), which I placed here https://github.com/c0va23/node-driver-registrar/pkgs/container/csi-node-driver-registrar.
Does this PR introduce a user-facing change?: