Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed clusters (windows+linux) #116

Closed
ghost opened this issue Dec 19, 2020 · 4 comments
Closed

mixed clusters (windows+linux) #116

ghost opened this issue Dec 19, 2020 · 4 comments
Assignees
@dr0pdb
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ghost
Copy link

ghost commented Dec 19, 2020

I am doing some tests with this diver and Helm on a windows+linux cluster.
However, the csi-nfs-node also gets triggered on windows nodes.

Could you hardcore a node selector for csi-nfs-node, or have a way to set a nodeselector via a Helm config override?
@andyzhangx
Copy link
Member

@dr0pdb could you help? could refer to setting in smb driver.

@andyzhangx andyzhangx added the kind/bug Categorizes issue or PR as related to a bug. label Dec 25, 2020
@dr0pdb
Copy link
Contributor

dr0pdb commented Dec 25, 2020

/assign

@dr0pdb
Copy link
Contributor

dr0pdb commented Dec 27, 2020

@andyzhangx @malikumaliku
I think #117 fixed this issue. We do have a node selector specified to deploy only on Linux nodes.

@ghost
Copy link
Author

ghost commented Jan 9, 2021

fix confirmed

sachinkumarsingh092 added a commit to sachinkumarsingh092/csi-driver-nfs that referenced this issue Jan 12, 2021
@sachinkumarsingh092
Squashed 'release-tools/' changes from c6a88c6..5f06d02
317c4dd 
5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 5f06d02
sachinkumarsingh092 added a commit to sachinkumarsingh092/csi-driver-nfs that referenced this issue Jan 15, 2021
@sachinkumarsingh092
Squashed 'release-tools/' changes from c6a88c6..9289fd1
5b7c450 
9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307 Make the spelling and boilerplate checks optional
5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 9289fd1
pohly pushed a commit to pohly/csi-driver-nfs that referenced this issue Jan 26, 2021
@k8s-ci-robot
Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
86ff580 
allow export registry name
dobsonj pushed a commit to dobsonj/csi-driver-nfs that referenced this issue Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#116 from shiftstack/merge-bot-master
564d13c 
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0pdb dr0pdb

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyzhangx @dr0pdb