Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add missing unit tests for controller server and utils #124

Merged
merged 1 commit into from
Jan 4, 2021
Merged

test: Add missing unit tests for controller server and utils #124

merged 1 commit into from
Jan 4, 2021

Conversation

dr0pdb
Copy link
Contributor

@dr0pdb dr0pdb commented Dec 31, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds some of the missing unit tests for the controller server and utils in pkg/nfs

Which issue(s) this PR fixes:

Fixes #121

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 31, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @dr0pdb!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @dr0pdb. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 31, 2020
@dr0pdb
Copy link
Contributor Author

dr0pdb commented Dec 31, 2020

This is in the draft state since I am still working on the Delete volume unit test. I'll mark it ready afterward.

@dr0pdb dr0pdb marked this pull request as ready for review January 3, 2021 14:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 459392446

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+6.9%) to 79.615%
Files with Coverage Reduction New Missed Lines %
pkg/nfs/controllerserver.go 2 74.44%
Totals Coverage Status
Change from base Build 459249346: 6.9%
Covered Lines: 496
Relevant Lines: 623
💛 - Coveralls

@dr0pdb
Copy link
Contributor Author

dr0pdb commented Jan 3, 2021

@andyzhangx This is ready for review.

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2021
andyzhangx
andyzhangx approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, dr0pdb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d2f222 into kubernetes-csi:master Jan 4, 2021
@dr0pdb dr0pdb deleted the test_coverage branch January 4, 2021 11:38
sachinkumarsingh092 pushed a commit to sachinkumarsingh092/csi-driver-nfs that referenced this pull request Jan 12, 2021
@k8s-ci-robot
Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-sp…
5f06d02 
…ellcheck-boilerplate-tests

Fix spelling and boilerplate errors
sachinkumarsingh092 added a commit to sachinkumarsingh092/csi-driver-nfs that referenced this pull request Jan 12, 2021
@sachinkumarsingh092
Squashed 'release-tools/' changes from c6a88c6..5f06d02
317c4dd 
5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 5f06d02
sachinkumarsingh092 added a commit to sachinkumarsingh092/csi-driver-nfs that referenced this pull request Jan 15, 2021
@sachinkumarsingh092
Squashed 'release-tools/' changes from c6a88c6..9289fd1
5b7c450 
9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307 Make the spelling and boilerplate checks optional
5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 9289fd1
dobsonj pushed a commit to dobsonj/csi-driver-nfs that referenced this pull request Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#124 from shiftstack/merge-bot-master
9a1f564 
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@msau42 msau42 Awaiting requested review from msau42

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve unit test coverage
4 participants
@dr0pdb @k8s-ci-robot @coveralls @andyzhangx