Tests fail on NixOS

[MagicRB]

What happened:
Test case test/e2e/e2e_suite_test.go:157 fails when buiding with Nix

What you expected to happen:
I expected tests to succeed as checking if the project directory ends in csi-driver-nfs doesn't make sense

How to reproduce it:
Try to build csi-driver-nfs on NixOS with pkgs.buildGoModule and you'll encounter this fun bug

Anything else we need to know?:

Environment:

• CSI Driver version: N/A
• Kubernetes version (use kubectl version): N/A
• OS (e.g. from /etc/os-release): NixOS
• Kernel (e.g. uname -a): N/A
• Install tools: N/A
• Others: N/A

Recommended Fix:
Delete that line

[andyzhangx]

hi @MagicRB would you submit a PR directly? thanks.

[andyzhangx]

and you could also contribute how to build this project in NixOS

[MagicRB]

I really don't want to go through the license agreement stuff, so unfortunately not at this time

[andyzhangx]

while I don't have NixOS, not sure how to fix this.

[MagicRB]

and another issue has cropped up, test/e2e/e2e_suite_test.go:26:2: imported and not used: "strings" which is really an easy fix as the first one. And as to NixOS building, that should really go into nixpkgs, which I'll do at some point.

while I don't have NixOS, not sure how to fix this.

there really only two things, which we can do, either delete that project name check or disable tests as I can't tell Nix to use a different folder, it would break the pureness of the build process.

[andyzhangx]

cc @dr0pdb

[MagicRB]

BTW, I pushed the Docker container builder to my Gitea instance, the builder builds this driver from Nix. It's easy to extract the Nix package from that. The advantage over regular Dockerfiles is truly reproducible builds and (generally) smaller images, seems to not be that pronounced with go apps

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.