Update release tools #133
Update release tools #133
Conversation
k8s-ci-robot
added
release-note-none
|
Welcome @sachinkumarsingh092! |
|
Hi @sachinkumarsingh092. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/cc @andyzhangx |
Pull Request Test Coverage Report for Build 488682245
💛 - Coveralls |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/approve |
k8s-ci-robot
added
the
approved
|
The failed test exits with: but the path does exist! Does it need an absolute path then? |
9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 9289fd1
…pelling-boilerplate-check
sachinkumarsingh092
force-pushed
the
enable-spelling-boilerplate-check
branch
from
9897c5e to
bf73c6c
Compare
| # This is for testing csi-release-tools itself in Prow. All other | ||
| # repos use prow.sh for that, but as csi-release-tools isn't a normal | ||
| # repo with some Go code in it, it has a custom Prow test script. | ||
|
|
||
| ./verify-shellcheck.sh "$(pwd)" | ||
| ./verify-spelling.sh "$(pwd)" |
There was a problem hiding this comment.
Is the goal to also enable these checks in the nfs repo? If so, we also need to add these calls to this repo's .prow.sh
There was a problem hiding this comment.
Is the goal to also enable these checks in the nfs repo?
Yes, but this PR is solely to update the release tools for nfs repo. I intend to make a separate PR for enabling these tests for the prow and in the makefile (by enabling them in hack/verify-all.sh) hence fixing #128. Is it okay?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, sachinkumarsingh092 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e7 README.md: document usage of --squash 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab1 fix: default boilerplate path 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6 prow.sh: fix "on-master" prow jobs git-subtree-dir: release-tools git-subtree-split: 7bc70e5
prow.sh: fix "on-master" prow jobs
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the release tools for this repository after which we can enable spelling and boilerplate checks.
Which issue(s) this PR fixes:
Part of #128
Special notes for your reviewer:
Does this PR introduce a user-facing change?: