prow.sh: enable -csi.checkpathcmd option in csi-sanity

[dobsonj]

This enables the -csi.checkpathcmd option, which is needed in order
to test if TargetPath was successfully removed by the CSI driver as
part of NodeUnpublishVolume.

This is a follow up to kubernetes-csi/csi-test#338
cc: @gnufied @pohly

[k8s-ci-robot]

Welcome @dobsonj!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dobsonj. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/release-note-none

[dobsonj]

FWIW, I tested this change under csi-test/release-tools and verified that the new test runs and passes there.

Node Service NodeUnpublishVolume
  should remove target path
  /root/go/src/csi-test/pkg/sanity/node.go:453
STEP: reusing connection to CSI driver at dns:///172.18.0.4:30931
STEP: creating mount and staging directories
STEP: creating a single node writer volume for expansion
STEP: Getting a node id
STEP: Staging and publishing a volume
STEP: node staging volume
STEP: publishing the volume on a node
STEP: Checking the target path exists
STEP: Unpublishing the volume
STEP: Checking the target path was removed
•
------------------------------

[pohly]

/ok-to-test

This now should be tested with the csi-driver-host-path repo...

[pohly]

Nope, I didn't add that driver repo. Might be worth adding.

[pohly]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pohly]

Looks like testing was indeed insufficient: it failed when updating csi-release-tools in csi-driver-host-path because the new flag was used with the old csi-test that didn't support it (https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-host-path/295/pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21/1395031426440630272/build-log.txt).

Fix in #152