Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-csi: test csi-release-tools against csi-driver-host-path #22248

Merged
merged 1 commit into from
May 19, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 19, 2021

Only csi-driver-host-path uses the csi-sanity support in
prow.sh. Because it wasn't tested, a regression slipped through pull
testing (kubernetes-csi/csi-release-tools#148 (comment)).

Only csi-driver-host-path uses the csi-sanity support in
prow.sh. Because it wasn't tested, a regression slipped through pull
testing (kubernetes-csi/csi-release-tools#148 (comment)).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from chases2 and wojtek-t May 19, 2021 16:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 19, 2021
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@pohly
Copy link
Contributor Author

pohly commented May 19, 2021

/assign @msau42

For approval.

@pohly
Copy link
Contributor Author

pohly commented May 19, 2021

Looks like I was racing with the bot... the PR is approved. I only saw the LGTM tag.

@k8s-ci-robot k8s-ci-robot merged commit 97195cc into kubernetes:master May 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key csi-release-tools-config.yaml using file config/jobs/kubernetes-csi/csi-release-tools/csi-release-tools-config.yaml

In response to this:

Only csi-driver-host-path uses the csi-sanity support in
prow.sh. Because it wasn't tested, a regression slipped through pull
testing (kubernetes-csi/csi-release-tools#148 (comment)).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants