Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.0 to make the new major release importable #237

Closed
Ntr0 opened this issue Nov 7, 2019 · 5 comments
Closed

Release v3.0.0 to make the new major release importable #237

Ntr0 opened this issue Nov 7, 2019 · 5 comments

Comments

@Ntr0
Copy link
Contributor

Ntr0 commented Nov 7, 2019

Without appropriate tagging it's still not possible to use semantic imports.

github.com/kubernetes-csi/csi-test/v3/pkg/sanity: module github.com/kubernetes-csi/csi-test/v3@latest (v3.0.0-20191106140151-d305288bda09) found, but does not contain package github.com/kubernetes-csi/csi-test/v3/pkg/sanity
@pohly
Copy link
Contributor

pohly commented Nov 7, 2019

It works when specifically selecting the "master" branch:

$ go version
go version go1.13.3 linux/amd64
$ go get github.com/kubernetes-csi/csi-test/v3/pkg/sanity@master
go: finding github.com master
go: finding github.com/kubernetes-csi/csi-test/v3 master
go: finding github.com/kubernetes-csi/csi-test/v3/pkg/sanity master
go: finding github.com/kubernetes-csi/csi-test master
go: finding github.com/kubernetes-csi master
go: finding github.com/kubernetes-csi/csi-test/v3/pkg master
go: downloading github.com/kubernetes-csi/csi-test/v3 v3.0.0-20191106140151-d305288bda09
go: extracting github.com/kubernetes-csi/csi-test/v3 v3.0.0-20191106140151-d305288bda09

Having said that, I agree that releasing v3.0.0 is urgent. That's why I want to get the API changes merged as soon as possible:

@pohly
Copy link
Contributor

pohly commented Nov 11, 2019

Also need to fix:

@pohly
Copy link
Contributor

pohly commented Nov 14, 2019

  • update csi-release-tools to get Go 1.13.6

@msau42
Copy link
Collaborator

msau42 commented Dec 6, 2019

3.0.0 is available now.
/close

@k8s-ci-robot
Copy link
Contributor

@msau42: Closing this issue.

In response to this:

3.0.0 is available now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stmcginnis pushed a commit to stmcginnis/csi-test that referenced this issue Oct 9, 2024
Add script to generate patch release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants