csi-sanity binary #234
Merged
csi-sanity binary #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
misterikkit
reviewed
Oct 29, 2019
cmd/csi-sanity/main.go
Outdated
|
|
||
| var ( | ||
| VERSION = "(dev)" | ||
| config = sanity.NewTestConfig() |
There was a problem hiding this comment.
This can be moved into main() now. (:
There was a problem hiding this comment.
@misterikkit can you also review PR #233? That needs to go in first.
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
cncf-cla: yes
pohly
force-pushed
the
csi-test-binary
branch
from
d53f998
to
7a596e1
Compare
|
/check-cla |
pohly
force-pushed
the
csi-test-binary
branch
from
7a596e1
to
29c009c
Compare
k8s-ci-robot
added
the
needs-rebase
The advantage is that "go get" works and that the useless "-test.*" command line parameters are no longer present.
pohly
force-pushed
the
csi-test-binary
branch
from
29c009c
to
0db297f
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
stmcginnis
pushed a commit
to stmcginnis/csi-test
that referenced
this pull request
Oct 9, 2024
fixed broken links of testgrid dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This enables "go get github.com/kubernetes-csi/csi-test/cmd/csi-sanity" and gets rid of useless "-test.*" parameters.
Special notes for your reviewer:
Builds on top of PR #233 which needs to be merged first.
Does this PR introduce a user-facing change?: