-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch verb for persistentvolumes resources in the external-provisioner-runner clusterrole #1155
add patch verb for persistentvolumes resources in the external-provisioner-runner clusterrole #1155
Conversation
To add a new RBAC rule, we need to bump the major version. |
I think we should probably do this following the K8s 1.30 release. |
Can we use patch instead of update? |
cc @deepakkinni |
Unfortunately, we use update https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/master/controller/controller.go#L1322-L1328 Having read about Patch now, I do see its benefits. Would you prefer if we switched out the update to patch? |
Yes, try to switch to patch, please. |
…ioner-runner clusterrole
305ad97
to
c597852
Compare
/hold Waiting for kubernetes-sigs/sig-storage-lib-external-provisioner#164 merged. |
Can you change from "update verb" to "patch verb" in the release note? |
@xing-yang updated. |
/approve |
@carlory Can we cancel the hold? |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, deepakkinni, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
we need to bump the vendor |
cc @xing-yang |
/hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
the feature-gate HonorPVReclaimPolicy is enabled, create a pvc with a delete relaim policy, then delete the pvc, the pv stuck in deleting status, the error message is:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: