Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-37617: STOR-1593: Rebase to upstream v5.0.2 for 4.17 #104

Merged
merged 9 commits into from
Aug 7, 2024

Conversation

rhrmo
Copy link

@rhrmo rhrmo commented Aug 7, 2024

Diff to upstream v5.0.2:
kubernetes-csi/external-provisioner@v5.0.2...rhrmo:rebase-v5.0.2

Changes between 4.0.1 (OCP 4.16) and 5.0.2:

Full upstream changelogs:
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.2/CHANGELOG/CHANGELOG-5.0.md

@openshift/storage

jsafrane and others added 9 commits August 6, 2024 14:29
Update sigs.k8s.io/sig-storage-lib-external-provisioner to the latest
release to fix removal of the PV finalizer.
This is a partial cherry pick of 6625a06 that fixed typos in the master
branch. These typos block merges in github.
988496a1f Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c698 chore: bump to Go 1.22.5
69bd71e8a chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd4 Merge pull request kubernetes-csi#256 from solumath/master
cfa92106c Instruction update
379a1bb9b Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbbb fix typo in sidecar release process
49676850e Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c2 Update skip list in codespell GitHub Action
f5aebfc9f Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
…-pick-of-#1250-upstream-release-5.0

Manual cherry pick of kubernetes-csi#1250: Update lib-external-provisioner to v10.0.1
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rhrmo: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Diff to upstream v5.0.1:
kubernetes-csi/external-provisioner@v5.0.2...rhrmo:rebase-v5.0.2

Changes between 4.0.1 (OCP 4.16) and 5.0.2:

Full upstream changelogs:
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.2/CHANGELOG/CHANGELOG-5.0.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Author

rhrmo commented Aug 7, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@rhrmo
Copy link
Author

rhrmo commented Aug 7, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rhrmo: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Diff to upstream v5.0.2:
kubernetes-csi/external-provisioner@v5.0.2...rhrmo:rebase-v5.0.2

Changes between 4.0.1 (OCP 4.16) and 5.0.2:

Full upstream changelogs:
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.2/CHANGELOG/CHANGELOG-5.0.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link

/label docs-approved
/label px-approved
/lgtm

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@jsafrane
Copy link

jsafrane commented Aug 7, 2024

this needs openshift/vmware-vsphere-csi-driver-operator#241 merged first

@rhrmo
Copy link
Author

rhrmo commented Aug 7, 2024

/retest

Copy link

openshift-ci bot commented Aug 7, 2024

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Aug 7, 2024

/retest

@jsafrane
Copy link

jsafrane commented Aug 7, 2024

/approve

Copy link

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@jsafrane
Copy link

jsafrane commented Aug 7, 2024

CI looks good, explicitly vSphere has succeeded.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rhrmo: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Diff to upstream v5.0.2:
kubernetes-csi/external-provisioner@v5.0.2...rhrmo:rebase-v5.0.2

Changes between 4.0.1 (OCP 4.16) and 5.0.2:

Full upstream changelogs:
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.2/CHANGELOG/CHANGELOG-5.0.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fe460e5 into openshift:master Aug 7, 2024
10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: csi-provisioner
This PR has been included in build csi-provisioner-container-v4.18.0-202408071712.p0.gfe460e5.assembly.stream.el9.
All builds following this will include this PR.

@jsafrane
Copy link

jsafrane commented Aug 8, 2024

/retitle OCPBUGS-37617: STOR-1593: Rebase to upstream v5.0.2 for 4.17

@openshift-ci openshift-ci bot changed the title STOR-1593: Rebase to upstream v5.0.2 for 4.17 OCPBUGS-37617: STOR-1593: Rebase to upstream v5.0.2 for 4.17 Aug 8, 2024
@openshift-ci-robot
Copy link

@rhrmo: Jira Issue OCPBUGS-37617: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37617 has been moved to the MODIFIED state.

In response to this:

Diff to upstream v5.0.2:
kubernetes-csi/external-provisioner@v5.0.2...rhrmo:rebase-v5.0.2

Changes between 4.0.1 (OCP 4.16) and 5.0.2:

Full upstream changelogs:
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.2/CHANGELOG/CHANGELOG-5.0.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants