Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes-sigs/sig-storage-lib-external-provisioner to fix #195 #209

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

rmb938
Copy link

@rmb938 rmb938 commented Jan 8, 2019

Fixes #195

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2019
@msau42
Copy link
Collaborator

msau42 commented Jan 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, rmb938

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3039329 into kubernetes-csi:master Jan 8, 2019
@rmb938 rmb938 deleted the updatelibexternal branch January 8, 2019 19:18
@rmb938
Copy link
Author

rmb938 commented Jan 9, 2019

Thanks @msau42. Would it be possible to get a release and a new container image built with this change?

@msau42
Copy link
Collaborator

msau42 commented Jan 10, 2019

Can you do a cherry-pick to release-1.0 branch, and then we can cut a new patch release

@rmb938
Copy link
Author

rmb938 commented Jan 10, 2019

Sure

k8s-ci-robot added a commit that referenced this pull request Jan 10, 2019
…tream-release-1.0

Automated cherry pick of #209: update kubernetes-sigs/sig-storage-lib-external-provisioner
msau42 added a commit that referenced this pull request Sep 18, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2019
…ry-pick-of-#209-upstream-release-1.0

Revert "Automated cherry pick of #209: update kubernetes-sigs/sig-storage-lib-external-provisioner"
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
…ckage

fix: go module requirements for semantic versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants