Don't use external-provisioner delete finalizer #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@msau42: GitHub didn't allow me to assign the following users: wongma7, rmb938. Note that only kubernetes-csi members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rhrmo
added a commit
to rhrmo/external-provisioner
that referenced
this pull request
Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 43bde065f Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo
added a commit
to rhrmo/external-provisioner
that referenced
this pull request
Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 43bde065f Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo
added a commit
to rhrmo/external-provisioner
that referenced
this pull request
Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 43bde065f Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo
added a commit
to rhrmo/external-provisioner
that referenced
this pull request
Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 43bde065f Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses #209 and #236.
There are still questions about if we should support handling the reclaim policy if PV is deleted first