Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #268

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

jsafrane
Copy link
Contributor

The PR template encourages people to fill /kind and release notes. Especially the release notes are going to be useful for CHANGELOG automation.

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from lpabon and sbezverk April 15, 2019 11:41
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit b30b111 into kubernetes-csi:master Apr 15, 2019
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
rhrmo added a commit to rhrmo/external-provisioner that referenced this pull request Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
43bde065f Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo added a commit to rhrmo/external-provisioner that referenced this pull request Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
43bde065f Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo added a commit to rhrmo/external-provisioner that referenced this pull request Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
43bde065f Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
rhrmo added a commit to rhrmo/external-provisioner that referenced this pull request Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
43bde065f Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
@rhrmo rhrmo mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants