-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common controller doesn't requeue on pvc finalizer remove err #957
Comments
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Related issue: kubernetes/kubernetes#84430 |
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@akalenyu: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@akalenyu: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What happened:
The common snapshot controller will not requeue if intermittent errors prevent the removal of the PVC finalizer, such as
The relevant code bit
external-snapshotter/pkg/common-controller/snapshot_controller.go
Lines 189 to 194 in facefba
What you expected to happen:
Finalizer removed
How to reproduce it:
Unit test is sufficient - inject an error to PVC Update() and observe that the controller doesn't return err/requeue
Anything else we need to know?:
Environment:
main branch of external-snapshotter
The text was updated successfully, but these errors were encountered: