Work around common snapshot controller issue in tests #2976
Conversation
kubevirt-bot
added
release-note-none
| // work around https://github.com/kubernetes-csi/external-snapshotter/issues/957 | ||
| // it does converge after the resync period of snapshot controller (15mins) | ||
| cc.AddAnnotation(snapshot, "workaround", "triggersync") | ||
| err = f.CrClient.Update(context.TODO(), snapshot) |
There was a problem hiding this comment.
So you are essentially just re-triggering a reconcile so it cleans up, what happens if that gets the same error, maybe retry a few times instead of just once? I don't know if that is overkill or not.
There was a problem hiding this comment.
Yeah good call I am not sure. It fails on
E1109 05:15:43.755196 1 snapshot_controller.go:191] error check and remove PVC finalizer for snapshot [datasource-test-63c30e708034]: snapshot controller failed to update datasource-test-63c30e708034 on API server: Operation cannot be fulfilled on persistentvolumeclaims "datasource-test-63c30e708034": the object has been modified; please apply your changes to the latest version and try again
There was a problem hiding this comment.
I think we won't need to retry more since 30 seconds have passed so it had plenty of time to catch up
akalenyu
force-pushed
the
wa-csi-snapshot-finalizer-bug
branch
from
a8207c1
to
6b5abc8
Compare
This issue prevents the common csi snapshot controller from removing it's PVC finalizer: kubernetes-csi/external-snapshotter#957 This causes us some pain in testing: https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job so let's try working around it. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
wa-csi-snapshot-finalizer-bug
branch
from
6b5abc8
to
db07eff
Compare
|
/test pull-containerized-data-importer-e2e-hpp-latest |
|
Seems that we can't do any better here, looks good. Maybe use a shorter timeout in the second waitPVCDeleted? Just a suggestion though. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherrypick release-v1.58 |
|
@akalenyu: new pull request created: #2996 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v1.57 |
|
@akalenyu: new pull request created: #2997 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This issue prevents the common csi snapshot controller from removing it's PVC finalizer:
kubernetes-csi/external-snapshotter#957
This causes us some pain in testing:
https://search.ci.kubevirt.io/?search=dataimportcron_test.go%3A138&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
so let's try working around it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: