-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add noauth support #449
Add noauth support #449
Conversation
This reverts commit a5a264d.
Add the needed config parsing to use noauth, and update the glide gophercloud reference to include the latest version with noauth support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@j-griffith I just tested this with my setup and it works well. Could we push to get it merged? |
/area openstack/standalone-cinder pls run |
Add the needed config parsing to use noauth, and update the glide gophercloud reference to include the latest version with noauth support.
37e03f2
to
ebe3fd1
Compare
@wongma7 Ahh, thanks! I was wondering about the glide updates!! |
/lgtm |
oops, glide-vc deleted the package we need :/ please edit the glide.lock file so it has the package: then do
(sorry for lack of docs around how we use glide, I am hoping we can move to golang/dep soon since that is supposed to be a much better experience) |
…ternal-storage into add_noauth_support
Thanks @wongma7 I noticed the failure and was digging at Glide to try and fix that. I actually was thinking of proposing an update to godep, but looks like that might take some coordination. Anyway, thanks again!! |
Was Running I'm only asking, because I'm vendoring |
@klausenbusk appears not, oops. you are not doing anything wrong, your looks okay to me: perhaps I could do a separate PR just to run glide install -v; glide-vc --use-lock-file again but anyhow the repo will reach desired state eventually |
While working on Pull kubernetes-retired#449 I missed something in the cleaning up the Glide files. Not sure if it got lost in the merge, or I dropped it inadvertently upon commit but regardless I unintentionally added a ton of gophercloud files to the vendor dir. This PR is a simple clean up of that. Ran: `glide install -v; glide-vc --use-lock-file` Should clean up the unnecessary files that were added.
@klausenbusk Sorry about that, @wongma7 actually pointed that out and I thought I had it sorted but it would appear I missed something upon the actual commit. I've submitted #471 to clean that up. |
No problem :)
Thank, I will rebase when it has been merged. |
This adds the basic config checking for noauth and creates a service client appropriately. This also requires an update to the glide version of gophercloud to a newer version that includes the newly added noauth package.