Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Add noauth support #449

Merged
merged 5 commits into from
Nov 16, 2017
Merged

Conversation

j-griffith
Copy link
Contributor

This adds the basic config checking for noauth and creates a service client appropriately. This also requires an update to the glide version of gophercloud to a newer version that includes the newly added noauth package.

This reverts commit a5a264d.
Add the needed config parsing to use noauth, and update the
glide gophercloud reference to include the latest version
with noauth support.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2017
Copy link
Contributor

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aglitke
Copy link
Contributor

aglitke commented Nov 13, 2017

@j-griffith I just tested this with my setup and it works well. Could we push to get it merged?

@wongma7
Copy link
Contributor

wongma7 commented Nov 14, 2017

/area openstack/standalone-cinder

pls run go get github.com/sgotti/glide-vc && glide-vc --use-lock-file, it's just to minimize the amount of vendor code we check in. I will merge!

Add the needed config parsing to use noauth, and update the
glide gophercloud reference to include the latest version
with noauth support.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2017
@j-griffith
Copy link
Contributor Author

@wongma7 Ahh, thanks! I was wondering about the glide updates!!

@wongma7
Copy link
Contributor

wongma7 commented Nov 15, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2017
@wongma7
Copy link
Contributor

wongma7 commented Nov 15, 2017

oops, glide-vc deleted the package we need :/

please edit the glide.lock file so it has the package: then do glide install -v; glide-vc --use-lock-file to get the noauth package again and prevent it from getting inadvertently deleted

   subpackages:
   - openstack
   - openstack/blockstorage/extensions/volumeactions
+  - openstack/blockstorage/noauth
   - openstack/blockstorage/v2/snapshots
   - openstack/blockstorage/v2/volumes
   - openstack/common/extensions

(sorry for lack of docs around how we use glide, I am hoping we can move to golang/dep soon since that is supposed to be a much better experience)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2017
@j-griffith
Copy link
Contributor Author

Thanks @wongma7 I noticed the failure and was digging at Glide to try and fix that. I actually was thinking of proposing an update to godep, but looks like that might take some coordination. Anyway, thanks again!!

@wongma7 wongma7 merged commit 5b76cfa into kubernetes-retired:master Nov 16, 2017
@klausenbusk
Copy link
Contributor

Was glide install -v; glide-vc --use-lock-file run before this was merged?

Running glide install -v; glide-vc --use-lock-file on master, removes around ~ 60k lines of code in vendor/github.com/gophercloud/gophercloud/openstack, code which was added in this commit.

I'm only asking, because I'm vendoring github.com/digitalocean/godo in #470, and it seems a bit odd, that adding a new dependency removes ~ 75k lines.

@wongma7
Copy link
Contributor

wongma7 commented Nov 18, 2017

@klausenbusk appears not, oops. you are not doing anything wrong, your looks okay to me: perhaps I could do a separate PR just to run glide install -v; glide-vc --use-lock-file again but anyhow the repo will reach desired state eventually

j-griffith added a commit to j-griffith/external-storage that referenced this pull request Nov 19, 2017
While working on Pull kubernetes-retired#449 I missed something in the cleaning up the
Glide files.  Not sure if it got lost in the merge, or I dropped it
inadvertently upon commit but regardless I unintentionally added a
ton of gophercloud files to the vendor dir.

This PR is a simple clean up of that.  Ran:
  `glide install -v; glide-vc --use-lock-file`

Should clean up the unnecessary files that were added.
@j-griffith j-griffith mentioned this pull request Nov 19, 2017
@j-griffith
Copy link
Contributor Author

@klausenbusk Sorry about that, @wongma7 actually pointed that out and I thought I had it sorted but it would appear I missed something upon the actual commit. I've submitted #471 to clean that up.

@klausenbusk
Copy link
Contributor

@klausenbusk Sorry about that

No problem :)

I've submitted #471 to clean that up.

Thank, I will rebase when it has been merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/openstack/standalone-cinder cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants