-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add DigitalOcean provisioner #470
Add DigitalOcean provisioner #470
Conversation
@klausenbusk: GitHub didn't allow me to request PR reviews from the following users: andrewsykim. Note that only kubernetes-incubator members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ready for review, CI is green and the vendoring "issue" has been solved. The Go flexvolume plugin is maybe a big ugly, but it gets the job done.. |
/lgtm I will create quay.io/kubernetes_incubator/digitalocean-flexplugin and quay.io/kubernetes_incubator/digitalocean-provisioner and give you write permissions to them after we merge. Thanks & sorry for the delay :) |
Great, I will rebase and remove the |
This commit add a DigitalOcean provisioner and a flexvolume plugin for DigitalOcean.
Done and ready for merge :) |
@wongma7 are we waiting on anything? or maybe I'm just a bit impatient.. |
Probably solvable when |
I think for solving the max count scheduling issue, you're looking for a generalized version of kubernetes/kubernetes#53461 |
Interesting (but mostly related to internal volume plugin, it seems (?)), I will play around with whatever gets implemented first. kubernetes/kubernetes#24317 also contain a few ideas. |
The comments in the PR suggest an alternative using ConfigMaps to better support out of tree cloud providers. |
Thanks @wongma7 Do you have time to create quay.io/kubernetes_incubator/digitalocean-provisioner and quay.io/kubernetes_incubator/digitalocean-flexplugin ? :) |
@klausenbusk yes, I have sent you an invite also Still trying to sort out and document how we should do versioning/release/auto-push for the repo, atm it needs a git tag to trigger build&push but that's not ideal. will create a github issue later. |
Great! I have just pushed both image as:
For now I'm just pushing as |
This commit add a DigitalOcean provisioner and a flexvolume plugin
for DigitalOcean.
Finally, here we go :) The code has only been tested slightly on my k8s 1.8 cluster.
I'm not sure if I did the vendoring correctly
(glide get github.com/digitalocean/godo
+glide-vc --use-lock-file
)..Edit: See commit messagesolved/cc @andrewsykim