This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
Log Stackdriver request when it fails. #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
k8s-ci-robot
added
size/XS
piosz
reviewed
Oct 2, 2017
| @@ -309,6 +310,12 @@ func (sink *StackdriverSink) sendOneRequest(req *sd_api.CreateTimeSeriesRequest) | |||
| var responseCode int | |||
| if err != nil { | |||
| glog.Warningf("Error while sending request to Stackdriver %v", err) | |||
| reqJson, errJson := json.Marshal(req) | |||
| if errJson != nil { | |||
| glog.Warningf("The request was %s", reqJson) | |||
There was a problem hiding this comment.
Also please print all requests as V(10)
k8s-ci-robot
added
size/S
piosz
reviewed
Oct 2, 2017
| func (sink *StackdriverSink) sendOneRequest(req *sd_api.CreateTimeSeriesRequest) { | ||
| startTime := time.Now() | ||
| empty, err := sink.stackdriverClient.Projects.TimeSeries.Create(fullProjectName(sink.project), req).Do() | ||
|
|
||
| var responseCode int | ||
| if err != nil { | ||
| glog.Warningf("Error while sending request to Stackdriver %v", err) | ||
| if glog.V(2) { | ||
| marshalRequestAndLog(func(reqJson []byte) { | ||
| glog.Warningf("The request was: %s", reqJson) |
There was a problem hiding this comment.
There is no such syntax. There is glog.V(2).Infof, however. Quoting from glog doc, those two calls are (almost) equivalent:
if glog.V(2) { glog.Info("log this") }
glog.V(2).Info("log this")
The only difference is, when V(2) is false, the expression inside won't get evaluated. I'm using the former, since instead of simply logging a string I'm also lazy-evaluating conversion to json.
There was a problem hiding this comment.
Sorry, I was not clear enough. When you are reading the code IMO it's easier to understand:
if glog.V(2) {
glog.V(2).Info("log this") }
}
than
if glog.V(2) {
glog.Warninf("log this") }
}
because in the second case your first impression is that the log severity is Warning, but then when you look closer, it turns out the this is in fact V(2).
| func (sink *StackdriverSink) sendOneRequest(req *sd_api.CreateTimeSeriesRequest) { | ||
| startTime := time.Now() | ||
| empty, err := sink.stackdriverClient.Projects.TimeSeries.Create(fullProjectName(sink.project), req).Do() | ||
|
|
||
| var responseCode int | ||
| if err != nil { | ||
| glog.Warningf("Error while sending request to Stackdriver %v", err) | ||
| if glog.V(2) { |
There was a problem hiding this comment.
How about adding a comment explaining this if?
| switch reflect.Indirect(reflect.ValueOf(err)).Type() { | ||
| case reflect.Indirect(reflect.ValueOf(&googleapi.Error{})).Type(): | ||
| responseCode = err.(*googleapi.Error).Code | ||
| default: | ||
| responseCode = httpResponseCodeUnknown | ||
| } | ||
| } else { | ||
| if glog.V(10) { |
| switch reflect.Indirect(reflect.ValueOf(err)).Type() { | ||
| case reflect.Indirect(reflect.ValueOf(&googleapi.Error{})).Type(): | ||
| responseCode = err.(*googleapi.Error).Code | ||
| default: | ||
| responseCode = httpResponseCodeUnknown | ||
| } | ||
| } else { | ||
| if glog.V(10) { | ||
| marshalRequestAndLog(func(reqJson []byte) { | ||
| glog.Infof("Stackdriver request sent: %s", reqJson) |
|
cc @loburm |
x13n
force-pushed
the
master
branch
2 times, most recently
from
62537e7
to
e48452a
Compare
Failed requests logged at log level 2. Successful ones logged at log level 10.
|
/lgtm |
|
@x13n could you please cherry-pick to release-1.4? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More data for debugging.