Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Log Stackdriver request when it fails. #1824

Merged
merged 1 commit into from
Oct 2, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions metrics/sinks/stackdriver/stackdriver.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package stackdriver

import (
"encoding/json"
"fmt"
"math/rand"
"net/url"
Expand Down Expand Up @@ -302,20 +303,41 @@ func (sink *StackdriverSink) requestSender(reqQueue chan *sd_api.CreateTimeSerie
}
}

func marshalRequestAndLog(printer func([]byte), req *sd_api.CreateTimeSeriesRequest) {
reqJson, errJson := json.Marshal(req)
if errJson != nil {
printer(reqJson)
} else {
glog.Errorf("Couldn't marshal Stackdriver request %v", errJson)
}
}

func (sink *StackdriverSink) sendOneRequest(req *sd_api.CreateTimeSeriesRequest) {
startTime := time.Now()
empty, err := sink.stackdriverClient.Projects.TimeSeries.Create(fullProjectName(sink.project), req).Do()

var responseCode int
if err != nil {
glog.Warningf("Error while sending request to Stackdriver %v", err)
// Convert request to json and log it, but only if logging level is equal to 2 or more.
if glog.V(2) {
marshalRequestAndLog(func(reqJson []byte) {
glog.V(2).Infof("The request was: %s", reqJson)
}, req)
}
switch reflect.Indirect(reflect.ValueOf(err)).Type() {
case reflect.Indirect(reflect.ValueOf(&googleapi.Error{})).Type():
responseCode = err.(*googleapi.Error).Code
default:
responseCode = httpResponseCodeUnknown
}
} else {
// Convert request to json and log it, but only if logging level is equal to 10 or more.
if glog.V(10) {
marshalRequestAndLog(func(reqJson []byte) {
glog.V(2).Infof("Stackdriver request sent: %s", reqJson)
}, req)
}
responseCode = empty.ServerResponse.HTTPStatusCode
}

Expand Down