Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: Update cert-controller #1484

Closed
yiqigao217 opened this issue Apr 21, 2021 · 1 comment · Fixed by #1487
Closed

HNC: Update cert-controller #1484

yiqigao217 opened this issue Apr 21, 2021 · 1 comment · Fixed by #1487
Assignees
@adrianludwin @yiqigao217
Milestone
hnc-v0.8

Comments

@yiqigao217
Copy link
Contributor

Cer-controller updated its WH support from v1beta1 to v1 (open-policy-agent/cert-controller#34). HNC has already updated to v1 for WHs (#1434) but our cert-controller still supports v1beta1:
https://github.com/kubernetes-sigs/multi-tenancy/blob/a6253034e7d197089b6d3003c459c5f394355dd7/incubator/hnc/vendor/github.com/open-policy-agent/cert-controller/pkg/rotator/rotator.go#L72-L74

It's currently working because the builtin type is still serving both v1beta1 and v1.

However after K8s v1.22, v1beta1 WH api will be unserved. We need to upgrade our cert-controller so HNC won't break.
@yiqigao217 yiqigao217 added this to the hnc-v0.8 milestone Apr 21, 2021
@yiqigao217 yiqigao217 self-assigned this Apr 21, 2021
@adrianludwin
Copy link
Contributor

/assign @adrianludwin

@adrianludwin adrianludwin mentioned this issue Apr 26, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adrianludwin adrianludwin

@yiqigao217 yiqigao217

Labels
None yet
Projects
None yet
Milestone
hnc-v0.8
Development

Successfully merging a pull request may close this issue.

Update cert-rotator to 0.2.0; tweak test targets adrianludwin/multi-tenancy
2 participants
@adrianludwin @yiqigao217