This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Update cert-rotator to 0.2.0; tweak test targets #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @yiqigao217 |
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
adrianludwin
changed the title
yiqigao217
reviewed
Apr 27, 2021
This change uses an "official" cert-rotator release for the first time, and includes support for v1 of all K8s APIs. It also introduces the "test-smoke" target that only runs the quickstart tests, to allow for faster local development. This allows developers to rely more heavily on the postsubmit and periodic tests we worked so hard to set up for HNC. Finally, it clarifies some of the warnings around HNC_REPAIR. Tested: make test-smoke passes. Tried running 'make test-e2e' with and without HNC_REPAIR set to verify that the warnings look correct in both cases.
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses an "official" cert-rotator release for the first time,
and includes support for v1 of all K8s APIs.
It also introduces the "test-smoke" target that only runs the quickstart
tests, to allow for faster local development. This allows developers to
rely more heavily on the postsubmit and periodic tests we worked so hard
to set up for HNC.
Finally, it clarifies some of the warnings around HNC_REPAIR.
Tested: make test-smoke passes. Tried running 'make test-e2e' with and
without HNC_REPAIR set to verify that the warnings look correct in both
cases.
Fixes #1484, #1295