-
Notifications
You must be signed in to change notification settings - Fork 172
Conversation
/assign @adrianludwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
/assign @rjbez17
Looks great but I wouldn't mind another set of eyes on this
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Seems |
Migrate apiextensions from v1beta1 to v1: 1. Upgrade controller-tools to generate kubebuilder markers to use v1 apis; 2. Replace v1beta1 with v1 in yaml files and patches; 3. Fix schema changes from v1beta1 to v1: a) SideEffects is required for v1 MWH, VWH; b) AdmissionReviewVersions is mandatory for v1; c) webhookClientConfig schema change in CRD; d) conversionReviewVersions in v1 CRD; e) add 1 more level of indention in enum singleton patch; f) add spec.scope and schema in testing CRD (they are required in v1); g) add `v1beta1` to CRD `spec.conversion.conversionReviewVersions` and VWH `admissionReviewVersions`, since it's required in K8s 1.16 cluster. 4. E2e test in 1.16 and 1.17 K8s cluster and `make test`(got below issue and fixed); 5. Reinstall latest kubebuilder since controller-runtime envtest uses etcd and kube-apiserver loaded by default from /usr/local/kubebuilder/bin. (TODO will document this in the next PR in `make test` and HNC developer README).
Tested on 1.16 cluster after adding |
/lgtm Did you need the hold still for some testing? Sounds like it's all good but I'll leave it just in case. |
lgtm as well - @yiqigao217 please cancel the hold when you're comfortable. |
/hold cancel |
Part of #1371
Migrate apiextensions from v1beta1 to v1:
apis;
a)
SideEffects
is required for v1 MWH, VWH;b)
AdmissionReviewVersions
is mandatory for v1;c)
webhookClientConfig
schema change in CRD;d)
conversionReviewVersions
in v1 CRD;e) add 1 more level of indention in enum singleton patch;
f) add
spec.scope
and schema in testing CRD (they are required in v1);g) add
v1beta1
to CRDspec.conversion.conversionReviewVersions
andVWH
admissionReviewVersions
, since it's required in K8s 1.16 cluster.make test
(got below issueand fixed);
etcd and kube-apiserver loaded by default from
/usr/local/kubebuilder/bin. (TODO will document this in the next PR in
make test
and HNC developer README).