-
Notifications
You must be signed in to change notification settings - Fork 173
More hermetic, unified builds #1022
More hermetic, unified builds #1022
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9eb3e1c
to
688d02a
Compare
688d02a
to
be67541
Compare
/assign @rjbez17 |
Thanks for the explanations! @adrianludwin can you help me resolve the comments (somehow I don't have that option). /lgtm |
/wip This conflicts with #1032 so I need to revise |
@adrianludwin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
be67541
to
114c30c
Compare
ff297a0
to
4fa7fbe
Compare
/hold cancel Updated to include multiplatform kubectl plugins. Tested by releasing to https://github.com/adrianludwin/multi-tenancy/releases/tag/hnc-v0.6.0-test1. |
@yiqigao217 Can you please re-review? Note that the hold is gone. Thanks, A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just 1 nit
c60e42d
to
219e18e
Compare
This commit makes two significant changes: * Includes the kustomize tool so that we don't need to either fetch it from the internet or rely on one being installed locally. * Replaces portions of the Cloud Build process with the equivalent steps from the Makefile so they can't get out of sync. As a side effect, this required a bit of refactoring in the makefile, and I've moved some lines around to be more closely located with the relevant recipes. I tried removing `kubebuilder` (I thought we just needed controller-gen) but it contains elements required by Ginkgo. Since it's rather large (>50MB) and doesn't affect the correctness of the binaries as they're built (only tested), I decided not to check it in. I did upgrade the version we use from a 2.0 alpha to the latest release (as of Aug 2020). Finally, this includes a small docs change that was mistakenly left out of an earlier PR. Tested: made all targets locally; confirmed `kubectl hns version` gave the expected result; pushed a test tag to my repo and used the HNC_RELEASE_REPO_OWNER flag to build a fake release from that tag.
219e18e
to
6b15d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This commit makes two significant changes:
from the internet or rely on one being installed locally.
from the Makefile so they can't get out of sync.
As a side effect, this required a bit of refactoring in the makefile,
and I've moved some lines around to be more closely located with the
relevant recipes.
I tried removing
kubebuilder
(I thought we just needed controller-gen)but it contains elements required by Ginkgo. Since it's rather large
(>50MB) and doesn't affect the correctness of the binaries as they're
built (only tested), I decided not to check it in. I did upgrade the
version we use from a 2.0 alpha to the latest release (as of Aug 2020).
Finally, this includes a small docs change that was mistakenly left out
of an earlier PR.
Tested: made all targets locally; confirmed
kubectl hns version
gavethe expected result; pushed a test tag to my repo and used the
HNC_RELEASE_REPO_OWNER flag to build a fake release from that tag.