-
Notifications
You must be signed in to change notification settings - Fork 172
HNC: Add support for plugin build for darwin amd64 #1032
HNC: Add support for plugin build for darwin amd64 #1032
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @tcnksm! |
Hi @tcnksm. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b117711
to
eabc4f1
Compare
eabc4f1
to
57550d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
Thanks for this change! I'll also try to backport it to 0.5.2 (which I think we'll release to fix the object webhook issue - likely next week).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, tcnksm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related issue: #1029
This PR adds support for building and uploading the plugin for the darwin (Mac) environment. I just follow the current way which is done by Linux build. This changes binary name of release so we need to update the guide as well. If the current way is ok then let me update the guide as well.