This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Support cluster-admin propagation and update docs #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than continuing to play whack-a-mole with the list of verbs HNC can propagate, this change allows it to perform all verbs on all resources. This is equivalent to `cluster-admin` so I've updated the docs accordingly (see also issue kubernetes-retired#1311). I also noticed that the docs referred to K8s v1.15, which is no longer supported, so I updated them to v1.16. Finally, this change adds the `HNC_FOCUS` makefile var, allowing you to say something like: ``` HNC_FOCUS=772 make test ``` which only runs the e2e tests with "772" in the title. Tested: All quickstart e2e tests pass. Updated the test for issue kubernetes-retired#772 and verified that it failed without the other changes in this commit, and passed with them.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @yiqigao217 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than continuing to play whack-a-mole with the list of verbs HNC
can propagate, this change allows it to perform all verbs on all
resources. This is equivalent to
cluster-adminso I've updated thedocs accordingly (see also issue #1311).
I also noticed that the docs referred to K8s v1.15, which is no longer
supported, so I updated them to v1.16.
Finally, this change adds the
HNC_FOCUSmakefile var, allowing you tosay something like:
which only runs the e2e tests with "772" in the title.
Tested: All quickstart e2e tests pass. Updated the test for issue #772
and verified that it failed without the other changes in this commit,
and passed with them.
Fixes #1311