Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: cannot propagate "admin" rolebindings anymore #772

Closed
adrianludwin opened this issue May 27, 2020 · 0 comments · Fixed by #776
Closed

HNC: cannot propagate "admin" rolebindings anymore #772

adrianludwin opened this issue May 27, 2020 · 0 comments · Fixed by #776
Milestone
hnc-v0.4

Comments

@adrianludwin
Copy link
Contributor

This used to work, but I think a newer version of K8s has a deletecollections verb that we didn't cover.
@adrianludwin adrianludwin added this to the hnc-v0.4 milestone May 27, 2020
@adrianludwin adrianludwin mentioned this issue May 27, 2020
Merged
adrianludwin added a commit to adrianludwin/multi-tenancy that referenced this issue Apr 27, 2021
@adrianludwin
Support cluster-admin propagation and update docs
9fde938 
Rather than continuing to play whack-a-mole with the list of verbs HNC
can propagate, this change allows it to perform all verbs on all
resources. This is equivalent to `cluster-admin` so I've updated the
docs accordingly (see also issue kubernetes-retired#1311).

I also noticed that the docs referred to K8s v1.15, which is no longer
supported, so I updated them to v1.16.

Finally, this change adds the `HNC_FOCUS` makefile var, allowing you to
say something like:

```
HNC_FOCUS=772 make test
```

which only runs the e2e tests with "772" in the title.

Tested: All quickstart e2e tests pass. Updated the test for issue kubernetes-retired#772
and verified that it failed without the other changes in this commit,
and passed with them.
@adrianludwin adrianludwin mentioned this issue Apr 27, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
hnc-v0.4
Development

Successfully merging a pull request may close this issue.

Let HNC propagate builtin admin rolebindings adrianludwin/multi-tenancy
1 participant
@adrianludwin